Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SMS domains from tooltips #3580

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Remove SMS domains from tooltips #3580

merged 1 commit into from
Jun 15, 2021

Conversation

alex-mechler
Copy link
Contributor

Details

Removes the @expensify.sms from phone numbers in tooltips

Fixed Issues

Fixes #3574

Tests / QA Steps

  1. Sign into an account
  2. Start or navigate to a chat with a user that has an SMS login.
  3. Hover their name in the LHN
  4. Verify the tooltip does not contain @expensify.sms
  5. Hover their name in the Header
  6. Verify the tooltip does not contain @expensify.sms

Tested On

  • Web
  • Mobile Web - Tooltips do not exist on mobile
  • Desktop
  • iOS - Tooltips do not exist on mobile
  • Android - Tooltips do not exist on mobile

Screenshots

Web

image
image

Mobile Web

Tooltips do not exist on mobile

Desktop

image
image

iOS

Tooltips do not exist on mobile

Android

Tooltips do not exist on mobile

@alex-mechler alex-mechler requested a review from a team June 14, 2021 17:12
@alex-mechler alex-mechler self-assigned this Jun 14, 2021
@MelvinBot MelvinBot requested review from HorusGoul and removed request for a team June 14, 2021 17:13
Copy link
Contributor

@HorusGoul HorusGoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HorusGoul HorusGoul merged commit 7a521b9 into main Jun 15, 2021
@HorusGoul HorusGoul deleted the amechler-sms-tooltip branch June 15, 2021 14:56
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.68-5🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@Expensify.sms is visible in the tooltip when hovering over the user
3 participants