Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3559 fix initial route after relogin #3634

Merged

Conversation

dklymenk
Copy link
Contributor

Details

Makes sure there is a reportID before rendering the navigator with initial route that depends on reportID.

Fixed Issues

Fixes #3559

Tests / QA Steps

  1. Sign into an account
  2. Sign out of the account
  3. Sign into a different account

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

3559-web.mp4

Mobile Web

3559-mweb.mp4

Desktop

3559-desktop.mov

iOS

3559-ios.mp4

Android

3559-android.mp4

Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thanks for fixing this

@johnmlee101
Copy link
Contributor

Will wait for @luacmartins to final approve/merge

Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@luacmartins luacmartins merged commit ce97fe2 into Expensify:main Jun 17, 2021
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.70-6🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When signing into an account after signing out, you are brought to /r/ instead of a chat
4 participants