Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: make switch between chat list and workspaces smoother #36420

Merged
merged 68 commits into from
Apr 25, 2024
Merged

perf: make switch between chat list and workspaces smoother #36420

merged 68 commits into from
Apr 25, 2024

Commits on Feb 13, 2024

  1. perf: use context for shared reports access

    @hurali97
    hurali97 committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    3088672 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    f33930e View commit details
    Browse the repository at this point in the history

  2. perf: improve renderItem and use FlatList

    @hurali97
    hurali97 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    6921051 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'main' into hur/perf/issue-35704

    @jbroma
    jbroma committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    4d267b4 View commit details
    Browse the repository at this point in the history

  2. refactor: revert changes to withCurrentReportID

    @jbroma
    jbroma committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    dc88950 View commit details
    Browse the repository at this point in the history

  3. refactor: remove useReports context & hooks

    @jbroma
    jbroma committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9ae8701 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. refactor: use reports from onyx in useOrderedReportIDs

    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    b613e97 View commit details
    Browse the repository at this point in the history

  2. refactor: move creating orderedReport objects from getOrderedReportId… 

    …s to the context itself
    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7f15fbc View commit details
    Browse the repository at this point in the history

  3. Revert "refactor: revert changes to withCurrentReportID" 

    This reverts commit dc88950.
    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7fa44fc View commit details
    Browse the repository at this point in the history

  4. refactor: remove comment in SidebarLinksData

    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ae12b00 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into hur/perf/issue-35704

    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    8087e59 View commit details
    Browse the repository at this point in the history

  6. refactor: rename useOrderedReportIDs to useOrderedReportListItems

    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    c87f579 View commit details
    Browse the repository at this point in the history

  7. perf: use memo for extraData in LHNOptionList

    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    df1069c View commit details
    Browse the repository at this point in the history

  8. fix: typescript fixes

    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    1d294bc View commit details
    Browse the repository at this point in the history

  9. fix: update reportActionsSelector to match the one from SidebarLinksData

    @jbroma
    jbroma committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7dfba43 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. fix: typescript issues

    @hurali97
    hurali97 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    696c5ee View commit details
    Browse the repository at this point in the history

  2. test: fix reassure failing test

    @hurali97
    hurali97 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    6739b58 View commit details
    Browse the repository at this point in the history

  3. revert: move option item data calculation to the renderItem component

    @hurali97
    hurali97 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    92fae0c View commit details
    Browse the repository at this point in the history

  4. fix: linting

    @hurali97
    hurali97 committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    596fd63 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2024

  1. test: fix failing test

    @hurali97
    hurali97 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e735658 View commit details
    Browse the repository at this point in the history

  2. fix: prettier

    @hurali97
    hurali97 committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    94fcc48 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    31f5ed4 View commit details
    Browse the repository at this point in the history

  2. refactor: rename to useReportIDs

    @hurali97
    hurali97 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    e0673e0 View commit details
    Browse the repository at this point in the history

  3. refactor: don't set currentReportID if it's on workspaces screen

    @hurali97
    hurali97 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    30ca303 View commit details
    Browse the repository at this point in the history

  4. refactor: remove dead code

    @hurali97
    hurali97 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    121b537 View commit details
    Browse the repository at this point in the history

  5. fix: linting

    @hurali97
    hurali97 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    9e41603 View commit details
    Browse the repository at this point in the history

  6. refactor: remove irrelevant changes

    @hurali97
    hurali97 committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    4a32841 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. fix: comments

    @hurali97
    hurali97 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    581d09d View commit details
    Browse the repository at this point in the history

  2. fix: safely check the nested properties

    @hurali97
    hurali97 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    fffe41a View commit details
    Browse the repository at this point in the history

  3. feat: add comments for extraData prop

    @hurali97
    hurali97 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    6b41bf7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    5f832f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    49e32fd View commit details
    Browse the repository at this point in the history

  2. fix: reassure tests

    @hurali97
    hurali97 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    6412711 View commit details
    Browse the repository at this point in the history

  3. fix: apply prettier

    @hurali97
    hurali97 committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    e3477b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    769f83a View commit details
    Browse the repository at this point in the history

  2. perf: check for the settings tab existence in screen params and early… 

    … return
    @hurali97
    hurali97 committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    30b319f View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    71978c2 View commit details
    Browse the repository at this point in the history

  2. feat: add selector from SidebarLinksData

    @hurali97
    hurali97 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8dba89b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    c39f358 View commit details
    Browse the repository at this point in the history

  4. fix: reassure tests

    @hurali97
    hurali97 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    f333232 View commit details
    Browse the repository at this point in the history

  5. fix: resolve merge conflicts

    @hurali97
    hurali97 committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    3557027 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. Merge branch 'main' into hur/perf/issue-35704

    @jbroma
    jbroma committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    335f1fa View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. refactor: use currentReportID from useReportIDs

    @hurali97
    hurali97 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    61ef588 View commit details
    Browse the repository at this point in the history

  2. refactor: remove unnecessary ref

    @hurali97
    hurali97 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    84aa5ac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'hur/perf/issue-35704' of https://github.com/callstack-i… 

    …nternal/Expensify-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    2d8f88a View commit details
    Browse the repository at this point in the history

  4. update comment is updateCurrentReportID function 

    Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
    @hurali97 @roryabraham
    hurali97 and roryabraham committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    8532c08 View commit details
    Browse the repository at this point in the history

  5. update comment in useReportIDs hook 

    Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
    @hurali97 @roryabraham
    hurali97 and roryabraham committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    ac465f3 View commit details
    Browse the repository at this point in the history

  6. refactor: make comment less verbose

    @hurali97
    hurali97 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    886622e View commit details
    Browse the repository at this point in the history

  7. refactor: remove irrelevant comment

    @hurali97
    hurali97 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    6d17116 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    91ed2e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4e1fbd2 View commit details
    Browse the repository at this point in the history

  2. refactor: reduce memo usage

    @hurali97
    hurali97 committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    2ef5c7f View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3bcc037 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    ab5bce3 View commit details
    Browse the repository at this point in the history

  2. fix: typecheck

    @hurali97
    hurali97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    9e4f464 View commit details
    Browse the repository at this point in the history

  3. refactor: remove unnecessary diff

    @hurali97
    hurali97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    20d798e View commit details
    Browse the repository at this point in the history

  4. refactor: leverage useOnyx hook instead of withOnyx HOC

    @hurali97
    hurali97 committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    6f20396 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    33fe888 View commit details
    Browse the repository at this point in the history

  2. fix: max depth exceeded error by not mutating allReports object

    @hurali97
    hurali97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    c791be0 View commit details
    Browse the repository at this point in the history

  3. fix: use inline options and relevant initialValue

    @hurali97
    hurali97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    4aa6b99 View commit details
    Browse the repository at this point in the history

  4. fix: remove not needed prop

    @hurali97
    hurali97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    459e86c View commit details
    Browse the repository at this point in the history

  5. fix: use correct prop in memo check

    @hurali97
    hurali97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    61fc9ce View commit details
    Browse the repository at this point in the history

  6. fix: use policies instead of policyMembers

    @hurali97
    hurali97 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    489c652 View commit details
    Browse the repository at this point in the history

  7. Apply workaround for initialValue

    @fabioh8010
    fabioh8010 committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    10c0c04 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. fix: failing SidebarOrderTest

    @hurali97
    hurali97 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    e075aee View commit details
    Browse the repository at this point in the history

  2. fix: typecheck

    @hurali97
    hurali97 committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    0d4637e View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'main' of https://github.com/callstack-internal/Expensif… 

    …y-App into hur/perf/issue-35704
    @hurali97
    hurali97 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    42068cc View commit details
    Browse the repository at this point in the history

  2. refactor: remove initialValues

    @hurali97
    hurali97 committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    821e4e0 View commit details
    Browse the repository at this point in the history