[No QA] Fix StagingDeployCash isAutomatedPullRequest check #3656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomatoToaster
approved these changes
Jun 17, 2021
|
Merging to test! I didn't change any source code that will affect iOS. |
|
🚀 Deployed to staging in version: 1.0.70-7🚀
|
|
🚀 Deployed to production in version: 1.0.73-3🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Following-up on #3173
It's mostly working, but there are two remaining issues that are resolved by this PR:
html_urlinstead of theurl–> we want the html url not the API urllisting things from the GitHub API by will default only return open things. But in this case we want to check for PRs in any state.Fixed Issues
Fixes borked
StagingDeployCashhere: #3593Tests
Merge to test. I also updated the unit tests here.
QA Steps
None.
Tested On
N/A – GitHub only