Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Checkout repo before attempting to update StagingDeployCash #3676

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Yesterday I merged a PR that uses a local git command to populate the deploy checklist (i.e: git log ...). However, this workflow does not checkout the repo, so the command fails because it's not run from inside a git repo.

This PR is a simple fix – just checkout the repo.

Fixed Issues

Fixes failed workflow run: https://github.com/Expensify/Expensify.cash/runs/2860322010

Tests

Merge, then retry the workflow from main.

QA Steps

None.

Tested On

N/A – GitHub only

@roryabraham roryabraham requested a review from a team as a code owner June 18, 2021 16:57
@roryabraham roryabraham self-assigned this Jun 18, 2021
@roryabraham roryabraham changed the title Checkout repo before attempting to update StagingDeployCash [No QA] Checkout repo before attempting to update StagingDeployCash Jun 18, 2021
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team June 18, 2021 16:57
@roryabraham
Copy link
Contributor Author

Going to see if PB will give me someone that's online.

@roryabraham roryabraham requested review from a team and removed request for MariaHCD June 18, 2021 17:01
@MelvinBot MelvinBot requested review from MariaHCD and removed request for a team June 18, 2021 17:01
@mountiny mountiny self-requested a review June 18, 2021 17:04
@roryabraham
Copy link
Contributor Author

Going to merge and retest. Didn't change anything in src/ or related to the RN code so no need to wait for E2E.

@roryabraham roryabraham merged commit baba3b9 into main Jun 18, 2021
@roryabraham roryabraham deleted the Rory-FixDeployBlocker branch June 18, 2021 17:06
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.71-1🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.73-3🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants