-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backwards Compatibility: Update UI for closed expense reports with expenses #36767
Backwards Compatibility: Update UI for closed expense reports with expenses #36767
Conversation
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Hi, @rayane-djouah is this PR ready for review? |
…for-closed-expense-reports-with-no-expenses
PR is ready for review @abdulrahuman5196 |
Reviewing now |
Could you kindly check on this? Screen.Recording.2024-02-22.at.1.51.48.PM.mov |
…for-closed-expense-reports-with-no-expenses
Asked in Slack regarding translation https://expensify.slack.com/archives/C01GTK53T8Q/p1708892197938799 |
Updated |
…for-closed-expense-reports-with-no-expenses
Reviewing now |
Still working on review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rayane-djouah , Could you kindly check on the below comment?
I checked the working of the PR. Seems to be working fine. Will check on the response for the above question and proceed accordingly. |
…for-closed-expense-reports-with-no-expenses
Updated |
Reviewing now |
Reviewer Checklist
Screenshots/VideosAndroid: NativeN/A Android: mWeb ChromeN/A iOS: NativeN/A iOS: mWeb SafariN/A MacOS: Chrome / SafariScreen.Recording.2024-03-04.at.11.31.48.PM.mp4MacOS: DesktopScreen.Recording.2024-03-05.at.12.02.10.AM.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @amyevans
🎀 👀 🎀
C+ Reviewed
Thanks! I probably do not have time to get through a review today but will prioritize tomorrow! |
…for-closed-expense-reports-with-no-expenses
Updated |
@rayane-djouah looks like there are conflicts here now! |
…lity-Update-UI-for-closed-expense-reports-with-no-expenses
Conflicts Resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
Fixed Issues
$ #36190
PROPOSAL: #36190 (comment)
Tests
Follow steps from this comment #36190 (comment)
Offline tests
N/A
QA Steps
same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
only testable on web:
Deleted.Report.Recording.2024-03-07.165113.mp4