-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track expense/self dm #37165
Merged
+135
−34
Merged
Track expense/self dm #37165
Changes from 41 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
500f458
added v1 changes
ishpaul777 07eb0d9
Merge branch 'Expensify:main' into trackExpense/selfDM
ishpaul777 7819bc1
Merge branch 'Expensify:main' into trackExpense/selfDM
ishpaul777 376b452
clean up and changes v2
ishpaul777 f16a19f
fixes selfDm reportName in LHN
ishpaul777 ad25805
show report in detination for tasks
ishpaul777 f6362ad
prettier diffs
ishpaul777 e120e7a
Merge branch 'Expensify:main' into trackExpense/selfDM
ishpaul777 ef11187
Merge branch 'main' into trackExpense/selfDM
ishpaul777 8d002ca
refactor after merge
ishpaul777 4ac87bb
prettier
ishpaul777 c8ae559
fixes leave option in header three dots
ishpaul777 9426035
fix conflicts after merge
ishpaul777 5d7a997
fix postfix for visible for self dm
ishpaul777 279592b
fix user-avatar an share destination issue
ishpaul777 266cea6
remove console log
ishpaul777 3d4e4c7
fixes infinite loading when first load
ishpaul777 02db6f0
fixes review comments
ishpaul777 806c248
fixes self dm not showing in lhn
ishpaul777 d834b4f
remove console log
ishpaul777 01379eb
fixes ts checks
ishpaul777 1964a61
Merge branch 'Expensify:main' into trackExpense/selfDM
ishpaul777 c6b2614
fixes private note comment
ishpaul777 2e30497
remove unnecessary whitespace change
ishpaul777 144fb48
fixes spanish translation
ishpaul777 339a6a8
fixes comment
ishpaul777 5acf3c8
Update src/libs/ReportUtils.ts
ishpaul777 01820f8
getMoneyRequestOptions
ishpaul777 4df1a51
Merge branch 'trackExpense/selfDM' of https://github.com/ishpaul777/A…
ishpaul777 e1cd7cc
modify for readibility
ishpaul777 f33be37
remove comments
ishpaul777 c0b06bb
fixes you postfix not showing up in profilepage
ishpaul777 c8e1e02
fixes comment as per suggestion
ishpaul777 c812725
formatting
ishpaul777 acfdae8
Merge branch 'trackExpense/selfDM' of https://github.com/ishpaul777/A…
ishpaul777 db38f3b
revert back changes
ishpaul777 68a348f
Update src/pages/ReportDetailsPage.tsx
ishpaul777 5d167b0
Update src/pages/home/HeaderView.js
ishpaul777 a67cbc8
Update src/libs/OptionsListUtils.ts
ishpaul777 80a0e44
fixes review comment
ishpaul777 ac5030f
Merge branch 'trackExpense/selfDM' of https://github.com/ishpaul777/A…
ishpaul777 a4d858f
lint fix
ishpaul777 5cfb38d
add comment for workaround
ishpaul777 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment for why we're doing this? same with the other spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thienlnam was there a reason to not include the
currentUser
in thereport.participantAccountIDs
? We're using this hack in multiple places as a reason.