Add New payments page #3727
Merged
Add New payments page #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stitesExpensify
dismissed stale reviews from luacmartins and marcaaron
via
13874c2
|
Updated |
luacmartins
previously approved these changes
Jun 30, 2021
|
If we could get this merged today that would be great :D |
|
@stitesExpensify I'll re-review and merge if you fix those conflicts! |
|
gah new conflicts!? Fixing rn |
|
I un-praise git. It's bad. |
roryabraham
reviewed
Jul 1, 2021
|
Updated for all comments! Thank you again for looking through so many times |
roryabraham
approved these changes
Jul 2, 2021
marcaaron
approved these changes
Jul 2, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
57 tasks
5 tasks
|
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
paultsimura
reviewed
Sep 5, 2024
| enterYourUsernameToGetPaidViaPayPal: 'Enter your username to get paid back via PayPal.', | ||
| payPalMe: 'PayPal.me/', | ||
| yourPayPalUsername: 'Your PayPal username', | ||
| addPayPalAccount: 'Add PayPal Account', | ||
| growlMessageOnSave: 'Your PayPal username was successfully added', | ||
| }, | ||
| paymentMethodList: { | ||
| addPaymentMethod: 'Add Payment Method', | ||
| accountLastFour: 'Account ending in', |
There was a problem hiding this comment.
FYI – we've ended up shortening this to just "Ending in" to save some space in #47104
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR:
<CreateMenu>to<PopoverMenu><PaymentsPage>to<AddPayPalMePage>because that's all it was<PaymentsPage><PaymentMethodsList>component/file which gets and displays all bank accounts, cards, your wallet, and your paypal.meFixed Issues
Fixes https://github.com/Expensify/Expensify/issues/166278
Tests/QA
Tested On
Screenshots
Web
2021-06-23_16-58-52.mp4
Mobile Web
2021-06-23_18-06-06.mp4
Desktop
2021-06-23_17-14-17.mp4
iOS
Uploading 2021-06-23_18-04-05.mp4…
Android
2021-06-23_19-27-17.mp4