Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Audit][Implementation] hasDraft replacement #37281

Merged
merged 31 commits into from
Apr 4, 2024
Merged

[Audit][Implementation] hasDraft replacement #37281

merged 31 commits into from
Apr 4, 2024

Commits on Feb 27, 2024

  1. remove hasDraft from Report model

    @kacper-mikolajczak
    kacper-mikolajczak committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    00c81de View commit details
    Browse the repository at this point in the history

  2. remove reportWithoutHasDraftSelector

    @kacper-mikolajczak
    kacper-mikolajczak committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d177314 View commit details
    Browse the repository at this point in the history

  3. use draft comment to calculate hasDraftComment

    @kacper-mikolajczak
    kacper-mikolajczak committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    eeec9ba View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. fix shouldREportBeInOptionList

    @kacper-mikolajczak
    kacper-mikolajczak committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    7b8a757 View commit details
    Browse the repository at this point in the history

  2. trim the comment for hasDraftComment calculations

    @kacper-mikolajczak
    kacper-mikolajczak committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9df353b View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2024

  1. create draft message store

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    8876c08 View commit details
    Browse the repository at this point in the history

  2. split gORIDs into smaller functions

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 4, 2024
    Configuration menu
    Copy the full SHA
    cdef526 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2024

  1. fixing complexity

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    2f0555f View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Revert "fixing complexity" 

    This reverts commit 2f0555f.
    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    74c658a View commit details
    Browse the repository at this point in the history

  2. Revert "split gORIDs into smaller functions" 

    This reverts commit cdef526.
    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    024a50c View commit details
    Browse the repository at this point in the history

  3. invalidate reports order on drafts change

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    3330608 View commit details
    Browse the repository at this point in the history

  4. remove hasDraft from tests

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    bb2da17 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. fix draftComment computation

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    b166c50 View commit details
    Browse the repository at this point in the history

  2. change name

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    3fddd59 View commit details
    Browse the repository at this point in the history

  3. remain ordering of default Option object

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    c1214ab View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. make saveReportComment delete drafts for empty comments

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    1b245b4 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    059ea4a View commit details
    Browse the repository at this point in the history

  3. do not save drafts with spaces only

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    e599e5b View commit details
    Browse the repository at this point in the history

  4. prepare draft comment util

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7e2c3c5 View commit details
    Browse the repository at this point in the history

  5. waitForCollectionCallback in DraftCommentUtils

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    a3cd97d View commit details
    Browse the repository at this point in the history

  6. rename draftCommentMap to draftCommentCollection

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    da1d823 View commit details
    Browse the repository at this point in the history

  7. merge & fix to main

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    7adfbc9 View commit details
    Browse the repository at this point in the history

  8. fix tests

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    67a8736 View commit details
    Browse the repository at this point in the history

  9. add draftComments to FlashList extraData

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    eff88de View commit details
    Browse the repository at this point in the history

  10. fix minor things

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    4b56f6f View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. merge main

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    c9d75e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. merge main

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    7b2c6bc View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. fix tests

    @kacper-mikolajczak
    kacper-mikolajczak committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    fa7415c View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. merge main

    @kacper-mikolajczak
    kacper-mikolajczak committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    1575de7 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. fix list reordering

    @kacper-mikolajczak
    kacper-mikolajczak committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    b52bb0b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into audit/implementation/hasDraft-replacement

    @kacper-mikolajczak
    kacper-mikolajczak committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    564933c View commit details
    Browse the repository at this point in the history