Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed swipe on composer #3733

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 23, 2021

Details

Fixed Issues

Fixes #3323

Tests | QA Steps

  1. Log in on the mobile app.
  2. Navigate to a conversation.
  3. Tap on compose box and write a long message (long enough to enable scrolling).
  4. Scroll the message to the top.
  5. You should be able to scroll the message without closing the Keyboard.
  6. Now swipe downwards with at least a distance equal to the height of the composer. The keyboard should close.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

swipe-i.mp4

Android

swipe-a.mp4

@parasharrajat parasharrajat requested a review from a team as a code owner June 23, 2021 16:50
@parasharrajat parasharrajat changed the title fix: swipe on composer Fixed swipe on composer Jun 23, 2021
@MelvinBot MelvinBot requested review from stitesExpensify and removed request for a team June 23, 2021 16:51
@stitesExpensify stitesExpensify merged commit 11476f7 into Expensify:main Jun 24, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@parasharrajat parasharrajat deleted the swipekeyboard branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slightly scrolling up in compose box will dismiss the keyboard
3 participants