-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache node_modules/gems/pods in workflows #3752
Conversation
@roryabraham you can have a look, and let me know what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good - just the comment about using single quotes instead of double quotes for consistency
@roryabraham, should I cache the |
Yes please! |
@roryabraham Done |
@mikeattara What about the gems and pods in the E2E tests? |
@roryabraham, I've cached them now. Thought the pods was updating and would not need to be cached |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, @mikeattara I'm approving these changes. But just FYI since we're live-testing them, my plan is to revert this PR if there are any issues. In that case, you'll have to follow-up with another PR to fix any issues.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging in version: 1.0.74-1🚀
|
@mikeattara I think that this may have caused an error in our last production deploy. Can you please look into that? |
@roryabraham looking into it |
Can you try re-deploying? |
@roryabraham, I think the issue is not with the cache but installing the pods |
Okay, thanks for investigating. Will keep this on my radar during the next prod deploy. |
Details
Cache
node_modules
in all tasks that install npm packages to speedup workflowsFixed Issues
Fixes #3627
Tests / QA Steps
Tested On
n/a – GitHub only.