-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS migration] Migrate 'SelectionList.perf-test.js', 'ReportActionItemSingleTest.js', 'LoginUtilsTest.js' and 'isEmptyString.js' tests to TypeScript #37531
Conversation
…mSingleTest.js', 'LoginUtilsTest.js' and 'isEmptyString.js' tests
# Conflicts: # src/types/onyx/Policy.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -88,8 +97,7 @@ function SelectionListWrapper(args) { | |||
onSelectRow={onSelectRow} | |||
initiallyFocusedOptionKey="item-0" | |||
ListItem={RadioListItem} | |||
// eslint-disable-next-line react/jsx-props-no-spreading | |||
{...args} | |||
canSelectMultiple={canSelectMultiple} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed that canSelectMultiple
is the only prop provided to SelectionListWrapper
, so I decided to simplify it
We did not find an internal engineer to review this PR, trying to assign a random engineer to #32026 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
This comment was marked as outdated.
This comment was marked as outdated.
@thienlnam looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
[TS migration] Migrate 'isEmptyString.js' test to TypeScript
[TS migration] Migrate 'LoginUtilsTest.js' test to TypeScript
[TS migration] Migrate 'ReportActionItemSingleTest.js' test to TypeScript
[TS migration] Migrate 'SelectionList.perf-test.js' test to TypeScript
Fixed Issues
$ #32026
$ #32027
$ #32028
$ #32029
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.