Fixed StagingDeployCash issue body

[parasharrajat]

Details

Added pagination so that all the automated PRs can be filtered while creating the StagingDeployCashBody issue Body.

Fixed Issues

$ fixes #3662

Tests

QA Steps

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[parasharrajat]

I think I need help with the Check here. I am not sure exactly why its failing, on local gh-action-validate has no errors.

[roryabraham]

I think I need help with the Check here. I am not sure exactly why its failing, on local gh-action-validate has no errors.

TL;DR Just run npm run gh-actions-build and commit the changes 😄

But in case you want a more detailed explanation ...

So there are two checks that happen here. gh-action-validate uses a json schema to validate our .yaml GitHub actions and workflows to the best of its ability. That script is here.

The other check that happens here requires a bit more context. There is this subtlety of JavaScript GitHub Actions:

GitHub downloads each action run in a workflow during runtime and executes it as a complete package of code before you can use workflow commands like run to interact with the runner machine. This means you must include any package dependencies required to run the JavaScript code.

So in practice, that means that when creating a JavaScript action, one has two choices:

1. Commit your node_modules (or at least, the subset used by your GitHub Actions)
2. Precompile your JavaScript actions with their dependencies into a single Node.js executable using ncc.

We didn't want to commit any of our node modules in this repo, so instead we use the second approach. The build script is here. You can see the result by looking at all our JavaScript GitHub Actions, and you'll notice each has:

1. An action metadata .yml file
2. A JavaScript source file.
3. A compiled JS file called index.js

So whenever changes are made to GH Actions, you need to recompile the GHA executables. In order to help prevent people forgetting to do that, we added another PR check here that executes this script. That script recompiles all the actions on the PR and will complain if there is diff, which is what is happening here:

[parasharrajat]

Thanks for the detailed Info. but I built actions before pushing. I will try again.

[roryabraham]

@parasharrajat Do you have a windows computer? Annoyingly, ncc has different output on a windows machine vs a Unix machine. So windows users have to run the gh-actions-build in a vm, docker container, EC2 instance, or something.

[parasharrajat]

No, Linux

[roryabraham]

Try running .github/scripts/verifyActions.sh locally?

[parasharrajat]

🤔

[roryabraham]

Okay, next I would try this:

rm -rf node_modules
npm i
npm run gh-actions-build
./github/scripts/verifyActions.sh

Other than that, you have to look through the diff and try to find out what's going on/why there is a difference. IDK what Linux flavor you have, but that might matter - you could try running the build script in an Ubuntu 20.04 VM?

[parasharrajat]

npm ci was it. Thanks for help.

[parasharrajat]

Updated. Thanks.

[roryabraham]

No blockers, just some small comments.

[parasharrajat]

Updated. Ready for review.

[roryabraham]

Okay, LGTM 👍

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging in version: 1.0.74-1🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅