Fix: Image shrinks while loading in carousel #37739

tienifr · 2024-03-05T12:41:59Z

Details

This PR hides the image while it's still loading and only shows the loading indicator then, to avoid the issue that image shrinks to default size (200x200) on native devices since its size is not known yet.

Fixed Issues

$ #35615
PROPOSAL: #35615 (comment)

Tests

Send many images to a report (about 5)
Press an image
Quickly press the arrows to navigate between those images in carousel
Verify that while image is still loading, we only shows the loading indicator

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Send many images to a report (about 5)
Press an image
Quickly press the arrows to navigate between those images in carousel
Verify that while image is still loading, we only shows the loading indicator

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-05.at.19.45.29-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-03-05.at.19.49.57-compressed.mov

iOS: Native

Screen.Recording.2024-03-05.at.19.42.15-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-03-05.at.19.43.07-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-05.at.19.51.34-compressed.mov

MacOS: Desktop

Screen.Recording.2024-03-05.at.19.51.34-compressed.mov

melvin-bot · 2024-03-05T12:52:02Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-03-05T12:52:24Z

There's an issue on mWeb Safari that the order of attachments in carousel is messed up. This issue already exists on main.

Screen.Recording.2024-03-05.at.19.43.07-compressed.mov

abdulrahuman5196 · 2024-03-07T15:48:13Z

src/components/Lightbox/index.tsx

@@ -217,7 +217,7 @@ function Lightbox({isAuthTokenRequired = false, uri, onScaleChanged: onScaleChan
                            >
                                <Image
                                    source={{uri}}
-                                    style={contentSize ?? DEFAULT_IMAGE_DIMENSION}
+                                    style={[contentSize ?? DEFAULT_IMAGE_DIMENSION, !contentSize && {opacity: 0}]}


Kindly remove inline styles.

And contentSize ?? DEFAULT_IMAGE_DIMENSION why are we still setting DEFAULT_IMAGE_DIMENSION and hiding via opacity.

@tienifr

~~Updated! Removed DEFAULT_IMAGE_DIMENSION fallback and used styles.opacity0.~~

We still need the default image size, otherwise Image's onLoad function wouldn't trigger.

invisibleImage: { opacity: 0, width: 200, height: 200, }

abdulrahuman5196 · 2024-03-08T13:23:21Z

@tienifr I am see loader shown for a moment even after the image is shown, even in your android video I am seeing the same.

could you kindly check on this?

tienifr · 2024-03-11T09:13:41Z

loader shown for a moment even after the image is shown

That already happened in production app:

video_2024-03-11_16-12-48.mp4

I noticed the loading on simulator is a little bit (not considerably) longer, maybe because dev app are slower that production.

abdulrahuman5196 · 2024-03-13T15:53:14Z

Reviewing now

tienifr · 2024-03-15T11:24:41Z

Bump @abdulrahuman5196.

tienifr · 2024-03-18T09:55:32Z

@abdulrahuman5196 Do we have any blocker?

abdulrahuman5196 · 2024-03-18T10:09:17Z

Hi, I will work on this today

abdulrahuman5196 · 2024-03-18T15:51:13Z

Sorry for the delay. I am reviewing now.

abdulrahuman5196 · 2024-03-18T17:42:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-18.at.10.59.19.PM.mp4

Android: mWeb Chrome

Screen.Recording.2024-03-18.at.11.09.24.PM.mp4

iOS: Native

Screen.Recording.2024-03-18.at.10.51.15.PM.mp4

iOS: mWeb Safari

Screen.Recording.2024-03-18.at.10.52.11.PM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-03-18.at.9.43.16.PM.mp4

MacOS: Desktop

Screen.Recording.2024-03-18.at.9.45.05.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @iwiznia

🎀 👀 🎀
C+ Reviewed

OSBotify · 2024-03-18T18:00:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-19T23:50:40Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-20T00:51:15Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 1.4.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-22T16:10:01Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.55-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: image shrinks while loading in carousel

0185162

tienifr marked this pull request as ready for review March 5, 2024 12:51

tienifr requested a review from a team as a code owner March 5, 2024 12:51

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team March 5, 2024 12:52

tienifr mentioned this pull request Mar 5, 2024

[HOLD for payment 2024-03-29] [$500] Android – Image is reduced for a moment when quickly slide forward/back images using arrows #35615

Closed

6 tasks

abdulrahuman5196 reviewed Mar 7, 2024

View reviewed changes

tienifr added 3 commits March 8, 2024 15:27

remove default image dimension and use predefined styles

5513d1a

Merge branch 'main' of https://github.com/tienifr/App into fix/35615

c447008

reapply default image size

b81f519

abdulrahuman5196 approved these changes Mar 18, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia March 18, 2024 17:50

iwiznia approved these changes Mar 18, 2024

View reviewed changes

iwiznia merged commit e4aff64 into Expensify:main Mar 18, 2024
16 of 17 checks passed

github-actions bot mentioned this pull request Mar 19, 2024

Deploy Checklist: New Expensify 2024-03-19 #38651

Closed

66 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Image shrinks while loading in carousel #37739

Fix: Image shrinks while loading in carousel #37739

tienifr commented Mar 5, 2024 •

edited

Loading

melvin-bot bot commented Mar 5, 2024

tienifr commented Mar 5, 2024 •

edited

Loading

abdulrahuman5196 Mar 7, 2024

tienifr Mar 8, 2024 •

edited

Loading

abdulrahuman5196 Mar 8, 2024

abdulrahuman5196 commented Mar 8, 2024

tienifr commented Mar 11, 2024 •

edited

Loading

abdulrahuman5196 commented Mar 13, 2024

tienifr commented Mar 15, 2024

tienifr commented Mar 18, 2024 •

edited

Loading

abdulrahuman5196 commented Mar 18, 2024

abdulrahuman5196 commented Mar 18, 2024

abdulrahuman5196 commented Mar 18, 2024 •

edited

Loading

abdulrahuman5196 left a comment

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

OSBotify commented Mar 20, 2024

OSBotify commented Mar 22, 2024

Fix: Image shrinks while loading in carousel #37739

Fix: Image shrinks while loading in carousel #37739

Conversation

tienifr commented Mar 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 5, 2024

tienifr commented Mar 5, 2024 • edited Loading

abdulrahuman5196 Mar 7, 2024

Choose a reason for hiding this comment

tienifr Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

abdulrahuman5196 Mar 8, 2024

Choose a reason for hiding this comment

abdulrahuman5196 commented Mar 8, 2024

tienifr commented Mar 11, 2024 • edited Loading

abdulrahuman5196 commented Mar 13, 2024

tienifr commented Mar 15, 2024

tienifr commented Mar 18, 2024 • edited Loading

abdulrahuman5196 commented Mar 18, 2024

abdulrahuman5196 commented Mar 18, 2024

abdulrahuman5196 commented Mar 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

OSBotify commented Mar 20, 2024

OSBotify commented Mar 22, 2024

tienifr commented Mar 5, 2024 •

edited

Loading

tienifr commented Mar 5, 2024 •

edited

Loading

tienifr Mar 8, 2024 •

edited

Loading

tienifr commented Mar 11, 2024 •

edited

Loading

tienifr commented Mar 18, 2024 •

edited

Loading

abdulrahuman5196 commented Mar 18, 2024 •

edited

Loading