fix(36381): blur composer on edit menu action #37861

jeremy-croff · 2024-03-07T01:34:40Z

Details

Fixed Issues

$ #36381
PROPOSAL: #36381 (comment)

Tests

Verify that no errors appear in the JS console

For web and desktop:

Open a report
Focus a composer
Hover a previous message and press the three dot menu
Ensure the composer is unfocused
Check that the keyboard arrows work for the popped out menu from the menu options
From a non focused composer
Hover a previous message and press the three dot menu
Ensure the composer is unfocused
Check that the keyboard arrows work for the popped out menu from the menu options
From a focused composer
Hover a previous message and press the quick reaction emojis
Ensure the composer is stays focused

For mobile:

Focus the composer
Click on a previous message to see the menu actions
Close it
Ensure the composer is still focused

Offline tests

When offline, perform the same steps to ensure the focus is lost when going to the three dot menu.

QA Steps

Verify that no errors appear in the JS console

Open a report
Focus a composer
Hover a previous message and press the three dot menu
Ensure the composer is unfocused
Check that the keyboard arrows work for the popped out menu from the menu options
From a focused composer
Hover a previous message and press the quick reaction emojis
Ensure the composer is stays focused

PR Author Checklist

Screenshots/Videos

Android: Native

2024-03-06_21-33-23.mp4

Android: mWeb Chrome

2024-03-06_21-18-59.mp4

iOS: Native

2024-03-06_20-34-18.mp4

iOS: mWeb Safari

2024-03-06_20-03-05.mp4

MacOS: Chrome / Safari

2024-03-06_19-31-48.mp4

MacOS: Desktop

2024-03-06_19-37-25.mp4

jeremy-croff · 2024-03-07T03:23:45Z

Note: During my testing against the latest main, I observed that the Android composer on the web behaves differently from the other mobile experiences. After opening up the menu actions of a row. IOS web, native and android native keeps it focused, android web does not. I confirmed this is unrelated to my changes. My changes are only changing the desktop flows where the mini context button is used.

melvin-bot · 2024-03-07T03:35:14Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2024-03-07T07:44:47Z

src/components/BaseMiniContextMenuItem.tsx

+    /**
+     * Can be used to control the click event, and for example whether or not to lose focus from the composer when pressing the item
+     */
+    shouldPreventDefault?: boolean;


I'm thinking is there any better name for this prop? shouldPreventDefault is vague to me, we don't know which default would it prevent until we read the description. What do you think?

I do see the point.
Preventdefault is a JavaScript api so when keeping it vague I intended it to just mean call the preventDefault api on all click events that click this action.

But if we want it to indicate the user experience, but would preventDefaultClickEvent be a bit better?

It's better, or we can shouldPreventDefaultFocusOnPress same as haha

App/src/components/OptionRow.tsx

Line 107 in 9302ade

shouldPreventDefaultFocusOnSelectRow = false,

hoangzinh · 2024-03-11T14:02:26Z

@jeremy-croff Step 13 looks redundant in "Tests" + Step 3 looks redundant in "QA Tests", doesn't it?

hoangzinh · 2024-03-11T14:31:27Z

@jeremy-croff could you help to fix Lint as well?

hoangzinh · 2024-03-11T14:36:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-11.at.21.40.51.android.mov

Android: mWeb Chrome

Screen.Recording.2024-03-11.at.21.43.16.android.chrome.mov

iOS: Native

Screen.Recording.2024-03-11.at.21.38.08.ios.mov

iOS: mWeb Safari

Screen.Recording.2024-03-11.at.21.47.23.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-11.at.21.28.31.web.mov

MacOS: Desktop

Screen.Recording.2024-03-11.at.21.31.59.desktop.mov

jeremy-croff · 2024-03-11T14:44:27Z

@jeremy-croff Step 13 looks redundant in "Tests" + Step 3 looks redundant in "QA Tests", doesn't it?

I feel like step 13 is an important new behavior that demonstrates that since the menu items are now focused when you press the 3 dot menu, it also activates the arrow keys of the keyboard, allowing you to switch between them. This previously didn't work.

Step 3, as part of QA, is the main flow that's addressed in the ticket; I'm unclear why it's redundant.

hoangzinh · 2024-03-11T14:50:03Z

I feel like step 13 is an important new behavior that demonstrates that since the menu items are now focused when you press the 3 dot menu

Doesn't it cover in step 5 & 9? Because from step 12, we can test step 13 without tapping on three-dot menu

Step 3, as part of QA, is the main flow that's addressed in the ticket; I'm unclear why it's redundant.

I mentioned it incorrectly. I mean step 9

jeremy-croff · 2024-03-11T15:18:32Z

I feel like step 13 is an important new behavior that demonstrates that since the menu items are now focused when you press the 3 dot menu

Doesn't it cover in step 5 & 9? Because from step 12, we can test step 13 without tapping on three-dot menu

Step 3, as part of QA, is the main flow that's addressed in the ticket; I'm unclear why it's redundant.

I mentioned it incorrectly. I mean step 9

Yep! When reading it in context you're totally right. Thanks. Updated.

hoangzinh

LGTM

OSBotify · 2024-03-11T16:01:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-12T18:50:30Z

🚀 Deployed to staging by https://github.com/bondydaa in version: 1.4.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-13T19:45:45Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jeremy-croff added 2 commits March 6, 2024 19:32

fix(36381): blur composer on edit

a20914a

Merge remote-tracking branch 'origin/main' into 36381

fcafb97

jeremy-croff marked this pull request as ready for review March 7, 2024 03:35

jeremy-croff requested a review from a team as a code owner March 7, 2024 03:35

melvin-bot bot requested review from hoangzinh and removed request for a team March 7, 2024 03:35

hoangzinh reviewed Mar 7, 2024

View reviewed changes

fix(36381): Update variable name

f392a07

fix(36381): prettier

b1b642c

hoangzinh approved these changes Mar 11, 2024

View reviewed changes

melvin-bot bot requested a review from bondydaa March 11, 2024 15:21

bondydaa approved these changes Mar 11, 2024

View reviewed changes

bondydaa merged commit 91dafcb into Expensify:main Mar 11, 2024
18 checks passed

github-actions bot mentioned this pull request Mar 12, 2024

Deploy Checklist: New Expensify 2024-03-12 #38162

Closed

84 tasks

melvin-bot bot mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-03-20] [$500] Chat - Two Modals Open Simultaneously During Text Editing #36381

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(36381): blur composer on edit menu action #37861

fix(36381): blur composer on edit menu action #37861

jeremy-croff commented Mar 7, 2024 •

edited

Loading

jeremy-croff commented Mar 7, 2024 •

edited

Loading

melvin-bot bot commented Mar 7, 2024

hoangzinh Mar 7, 2024

jeremy-croff Mar 8, 2024

hoangzinh Mar 9, 2024

jeremy-croff Mar 10, 2024

hoangzinh commented Mar 11, 2024

hoangzinh commented Mar 11, 2024

hoangzinh commented Mar 11, 2024 •

edited

Loading

jeremy-croff commented Mar 11, 2024

hoangzinh commented Mar 11, 2024 •

edited

Loading

jeremy-croff commented Mar 11, 2024 •

edited

Loading

hoangzinh left a comment

OSBotify commented Mar 11, 2024

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

fix(36381): blur composer on edit menu action #37861

fix(36381): blur composer on edit menu action #37861

Conversation

jeremy-croff commented Mar 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

jeremy-croff commented Mar 7, 2024 • edited Loading

melvin-bot bot commented Mar 7, 2024

hoangzinh Mar 7, 2024

Choose a reason for hiding this comment

jeremy-croff Mar 8, 2024

Choose a reason for hiding this comment

hoangzinh Mar 9, 2024

Choose a reason for hiding this comment

jeremy-croff Mar 10, 2024

Choose a reason for hiding this comment

hoangzinh commented Mar 11, 2024

hoangzinh commented Mar 11, 2024

hoangzinh commented Mar 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

jeremy-croff commented Mar 11, 2024

hoangzinh commented Mar 11, 2024 • edited Loading

jeremy-croff commented Mar 11, 2024 • edited Loading

hoangzinh left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 11, 2024

OSBotify commented Mar 12, 2024

OSBotify commented Mar 13, 2024

jeremy-croff commented Mar 7, 2024 •

edited

Loading

jeremy-croff commented Mar 7, 2024 •

edited

Loading

hoangzinh commented Mar 11, 2024 •

edited

Loading

hoangzinh commented Mar 11, 2024 •

edited

Loading

jeremy-croff commented Mar 11, 2024 •

edited

Loading