Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update REVIEWER_CHECKLIST.md to include better Design guidance #37863

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Update REVIEWER_CHECKLIST.md to include better Design guidance #37863

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec9f012
Update REVIEWER_CHECKLIST.md to include better Design guidance
shawnborton Mar 7, 2024
bd0883a
Update REVIEWER_CHECKLIST.md
shawnborton Mar 7, 2024
95d2081
Update contributingGuides/REVIEWER_CHECKLIST.md
shawnborton Mar 7, 2024
70820b2
Update PR author checklist too
shawnborton Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contributingGuides/REVIEWER_CHECKLIST.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@
- [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like `Avatar` is modified, I verified that `Avatar` is working as expected in all cases)
- [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- [ ] If the PR modifies the form input styles:
- [ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- [ ] I verified that all the inputs inside a form are aligned with each other.
- [ ] I added `Design` label so the design team can review the changes.
- [ ] I added `Design` label and/or tagged `@expensify/design` so the design team can review the changes.
shawnborton marked this conversation as resolved.
Show resolved Hide resolved
- [ ] If a new page is added, I verified it's using the `ScrollView` component to make it scrollable when more elements are added to the page.
- [ ] If the `main` branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the `Test` steps.
- [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Expand Down
Loading