Fix: IOU-Error message remains on IOU report even same error message is dismissed from 1:1 #37875

tienifr · 2024-03-07T09:48:52Z

Details

Fixed Issues

$ #34189
PROPOSAL: #34189 (comment)

Tests

Flow 1:

Log in with separate accounts in the main testing device and a secondary device
In the main testing device create an IOU with a user
Disable the internet connection in the main testing device
In the main testing device (while offline) cancel the IOU
In the secondary device (online) mark the IOU as paid with the option "Settled up elsewhere"
Enable the internet connection in the main testing device
Verify a red dot appears on the chat in LHN
Tap the X from the conversation or IOU report
Go to IOU report or conversation
Verify that the X error is not appear into both reports

Flow 2:

On the main device, create a request
On the second device, pay the above request
On the main device, create another request
Then we see a error in the main chat and IOU chat
Dismiss error in main chat or IOU chat
Verify that the X error is not appear into both reports

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Flow 1:

Log in with separate accounts in the main testing device and a secondary device
In the main testing device create an IOU with a user
Disable the internet connection in the main testing device
In the main testing device (while offline) cancel the IOU
In the secondary device (online) mark the IOU as paid with the option "Settled up elsewhere"
Enable the internet connection in the main testing device
Verify a red dot appears on the chat in LHN
Tap the X from the conversation or IOU report
Go to IOU report or conversation
Verify that the X error is not appear into both reports

Flow 2:

On the main device, create a request
On the second device, pay the above request
On the main device, create another request
Then we see a error in the main chat and IOU chat
Dismiss error in main chat or IOU chat
Verify that the X error is not appear into both reports

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-07.at.17.12.49.mov

Screen.Recording.2024-03-07.at.17.13.56.mp4

Android: mWeb Chrome

Screen.Recording.2024-03-07.at.17.08.48.mov

Screen.Recording.2024-03-07.at.17.09.50.mov

iOS: Native

Screen.Recording.2024-03-07.at.17.27.48.mov

Screen.Recording.2024-03-07.at.17.28.36.mp4

iOS: mWeb Safari

Screen.Recording.2024-03-07.at.16.59.54.mov

Screen.Recording.2024-03-07.at.17.01.32.mov

MacOS: Chrome / Safari

Screen.Recording.2024-01-22.at.18.00.00.mov

MacOS: Desktop

Screen.Recording.2024-03-07.at.16.35.25.mp4

Screen.Recording.2024-03-07.at.16.33.26.mp4

…is dismissed

melvin-bot · 2024-03-07T09:49:08Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2024-03-11T02:39:17Z

@DylanDylann Can you help review my PR when you have a chance? Thanks

DylanDylann · 2024-03-11T07:27:23Z

src/libs/actions/ReportActions.ts

+    }
+}
+
+export {clearReportActionErrors, clearAllRelatedReportActionErrors};


Suggested change

export {clearReportActionErrors, clearAllRelatedReportActionErrors};

export {clearAllRelatedReportActionErrors};

@DylanDylann Should we remove this function? We still use it in other places such as IOUTest.js

whoops, Yeah let's keep it exported

If it's only used in a test, can we update the test to use the next function?

DylanDylann · 2024-03-11T11:07:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-20.at.12.03.55.mov

Android: mWeb Chrome

m.mp4

iOS: Native

Screen.Recording.2024-03-20.at.11.42.30.mp4

iOS: mWeb Safari

Screen.Recording.2024-03-20.at.11.39.45.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-20.at.11.34.40.mov

Screen.Recording.2024-03-20.at.11.35.58.mov

MacOS: Desktop

Screen.Recording.2024-03-20.at.11.41.23.mov

DylanDylann · 2024-03-12T15:02:31Z

Still testing

DylanDylann · 2024-03-14T07:05:32Z

@tienifr Your change looks good. Please help to merge the main then I can make a final testing

DylanDylann · 2024-03-14T07:15:47Z

src/libs/actions/ReportActions.ts

@@ -33,14 +35,55 @@ function clearReportActionErrors(reportID: string, reportAction: ReportAction) {
        return;
    }

+    if (keys) {


This is to handle cases with multiple errors in the same report action, right?

It may be a good improvement but It is not mentioned in the issue. Why do you think It is our expectation? Do you confirm with the design team or any internal engineer about that?

This is to handle cases with multiple errors in the same report action, right?

Yes

Why do you think It is our expectation?

When users click x button, we'll clear all errors of that action, so the related action can share some same errors and we need to clear all of them. I believe it's the expectation in the OP

I agree that's the expectation

DylanDylann · 2024-03-14T07:21:23Z

src/libs/actions/ReportActions.ts

+        const parentReportAction = ReportActionUtils.getReportAction(report.parentReportID, report.parentReportActionID);
+        const parentErrorKeys = Object.keys(parentReportAction?.errors ?? {}).filter((err) => errorKeys.includes(err));
+
+        clearAllRelatedReportActionErrors(report.parentReportID, parentReportAction, 'child', parentErrorKeys);


Please point out 1 case where we need to call clearAllRelatedReportActionErrors instead of clearReportActionErrors.
The current logic is fine but I am not sure if we need it or not

I already used it in

https://github.com/Expensify/App/pull/37875/files#diff-f0bdc7ab41060e24e6bcdc847f25185b372c5f9a072251fe5d3cae2a27887920R826

Pls correct me if I misunderstand sth

DylanDylann · 2024-03-18T07:32:46Z

src/libs/actions/ReportActions.ts

+        const childActions = ReportActionUtils.getAllReportActions(reportAction.childReportID);
+        Object.values(childActions).forEach((action) => {
+            const childErrorKeys = Object.keys(action.errors ?? {}).filter((err) => errorKeys.includes(err));
+            clearAllRelatedReportActionErrors(reportAction.childReportID ?? '', action, 'parent', childErrorKeys);


Please point out 1 case where we need to call clearAllRelatedReportActionErrors instead of clearReportActionErrors.
The current logic is fine but I am not sure if we need it or not

@tienifr For this point, I mean that in here

Well, we need to use clearAllRelatedReportActionError here since we need to clear the errors of the grandchildren/grandparent report actions. Currently we do not have any such cases but in the future there may be. clearAllRelatedReportActionErrors is more general than clearReportActionErrors so I believe it's better

DylanDylann

LGTM

amyevans

There's a conflict to fix as well!

src/libs/actions/ReportActions.ts

amyevans · 2024-03-20T15:23:35Z

src/libs/actions/ReportActions.ts

+    }
+}
+
+export {clearReportActionErrors, clearAllRelatedReportActionErrors};


If it's only used in a test, can we update the test to use the next function?

amyevans · 2024-03-20T15:24:08Z

src/libs/actions/ReportActions.ts

@@ -33,14 +35,55 @@ function clearReportActionErrors(reportID: string, reportAction: ReportAction) {
        return;
    }

+    if (keys) {


I agree that's the expectation

DylanDylann · 2024-03-21T07:11:07Z

@tienifr Should we add more tests for the new function?

cc @amyevans

amyevans · 2024-03-21T16:01:08Z

Yes, anytime we can reasonably write a test we should.

Also the Reassure performance tests are failing, although merging main should clear that up I believe.

tienifr · 2024-03-22T03:42:46Z

@DylanDylann Added tests

tests/actions/IOUTest.js

tienifr · 2024-03-25T04:13:30Z

@DylanDylann Added tests

DylanDylann · 2024-03-25T04:27:23Z

Looks good. @amyevans All yours

amyevans

Thanks!

OSBotify · 2024-03-25T14:47:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

tienifr added 5 commits February 19, 2024 10:41

fix: IOU-Error message remains on IOU report even same error message …

b4d4e1e

…is dismissed

Merge branch 'main' into fix/34189

5ff118c

refactor

9d8885a

Merge branch 'main' into fix/34189

0a7462c

refactor code

c072564

tienifr marked this pull request as ready for review March 7, 2024 09:49

tienifr requested a review from a team as a code owner March 7, 2024 09:49

melvin-bot bot requested review from DylanDylann and removed request for a team March 7, 2024 09:49

resolve conflict

581464c

DylanDylann reviewed Mar 11, 2024

View reviewed changes

Merge branch 'main' into fix/34189

e2a9c26

DylanDylann reviewed Mar 14, 2024

View reviewed changes

DylanDylann reviewed Mar 18, 2024

View reviewed changes

Merge branch 'main' into fix/34189

4606d18

DylanDylann approved these changes Mar 20, 2024

View reviewed changes

melvin-bot bot requested a review from amyevans March 20, 2024 04:52

amyevans requested changes Mar 20, 2024

View reviewed changes

fix conflicts and clean code

d201dea

tienifr added 3 commits March 22, 2024 10:26

Merge branch 'main' into fix/34189

ae7b13e

Merge branch 'main' into fix/34189

d48692e

add test

db0453a

DylanDylann reviewed Mar 22, 2024

View reviewed changes

tests/actions/IOUTest.js Outdated Show resolved Hide resolved

tienifr added 3 commits March 25, 2024 11:01

add test for transaction report actions

130b6df

refactor

439ffc9

lint fix

82bb67f

amyevans approved these changes Mar 25, 2024

View reviewed changes

amyevans merged commit b3baa68 into Expensify:main Mar 25, 2024
15 checks passed

github-actions bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

kbecciv mentioned this pull request Mar 28, 2024

[$250] IOU - RBR appears then disappears from IOU preview component & LHN #39174

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 29, 2024

[HOLD for payment 2024-04-05] [$500] IOU-Error message remains on IOU report even same error message is dismissed from 1:1 #34189

Closed

6 tasks

dominictb mentioned this pull request Jun 17, 2024

[HOLD][$250] Send invoice - Unable to dismiss error after editing the amount of paid invoice #43577

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: IOU-Error message remains on IOU report even same error message is dismissed from 1:1 #37875

Fix: IOU-Error message remains on IOU report even same error message is dismissed from 1:1 #37875

tienifr commented Mar 7, 2024 •

edited

Loading

melvin-bot bot commented Mar 7, 2024

tienifr commented Mar 11, 2024

DylanDylann Mar 11, 2024

tienifr Mar 12, 2024

DylanDylann Mar 12, 2024

amyevans Mar 20, 2024

DylanDylann commented Mar 11, 2024 •

edited

Loading

DylanDylann commented Mar 12, 2024

DylanDylann commented Mar 14, 2024

DylanDylann Mar 14, 2024

tienifr Mar 15, 2024

amyevans Mar 20, 2024

DylanDylann Mar 14, 2024

tienifr Mar 15, 2024

DylanDylann Mar 18, 2024 •

edited

Loading

tienifr Mar 19, 2024

DylanDylann left a comment

amyevans left a comment

amyevans Mar 20, 2024

amyevans Mar 20, 2024

DylanDylann commented Mar 21, 2024

amyevans commented Mar 21, 2024

tienifr commented Mar 22, 2024

tienifr commented Mar 25, 2024

DylanDylann commented Mar 25, 2024

amyevans left a comment

OSBotify commented Mar 25, 2024

	export {clearReportActionErrors, clearAllRelatedReportActionErrors};
	export {clearAllRelatedReportActionErrors};

Fix: IOU-Error message remains on IOU report even same error message is dismissed from 1:1 #37875

Fix: IOU-Error message remains on IOU report even same error message is dismissed from 1:1 #37875

Conversation

tienifr commented Mar 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 7, 2024

tienifr commented Mar 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann commented Mar 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Mar 12, 2024

DylanDylann commented Mar 14, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann Mar 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann left a comment

Choose a reason for hiding this comment

amyevans left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DylanDylann commented Mar 21, 2024

amyevans commented Mar 21, 2024

tienifr commented Mar 22, 2024

tienifr commented Mar 25, 2024

DylanDylann commented Mar 25, 2024

amyevans left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 25, 2024

tienifr commented Mar 7, 2024 •

edited

Loading

DylanDylann commented Mar 11, 2024 •

edited

Loading

DylanDylann Mar 18, 2024 •

edited

Loading