Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New: Added drafts in GSD / #focus mode #3793

Merged
merged 2 commits into from
Jul 1, 2021
Merged

New: Added drafts in GSD / #focus mode #3793

merged 2 commits into from
Jul 1, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jun 29, 2021 •
edited
Loading

Details

Added support for draft messages filter in Options for Sidebar.

Fixed Issues

$ Fixes #3782

Test | QA Steps

1. Log in to e.cash
2. Navigate to a conversation and type a message (do not send it)
3. Navigate to LHN
4. Navigate to Preferences
5. Enable focus mode
6. Navigate to LHN
7. You should all the chats in LHn that have a draft message.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

draft-w.mp4

Mobile Web

draft-m.mp4

Desktop

draft-d.mp4

iOS

Android

draft-a.mp4

@parasharrajat parasharrajat marked this pull request as ready for review June 30, 2021 15:45
@parasharrajat parasharrajat requested a review from a team as a code owner June 30, 2021 15:45
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team June 30, 2021 15:45
Jag96
Jag96 suggested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 2 minor comments but this works well!

src/libs/OptionsListUtils.js Show resolved Hide resolved
src/libs/OptionsListUtils.js Outdated Show resolved Hide resolved
@parasharrajat
Copy link
Member Author

@Jag96 Updated.

Jag96
Jag96 approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit c570743 into Expensify:main Jul 1, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat parasharrajat mentioned this pull request Jul 2, 2021
Closed
@shawnborton shawnborton mentioned this pull request Jul 6, 2021
Merged
5 tasks
@OSBotify OSBotify mentioned this pull request Jul 7, 2021
Closed
57 tasks
@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HOLD for payment July 7] Focus mode - Show draft messages in #focus
4 participants
@parasharrajat @OSBotify @roryabraham @Jag96