Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable creating P2P distance requests #37947

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Enable creating P2P distance requests #37947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00f7d55
Add new p2p params to CreateDistanceRequest
neil-marcellini Mar 8, 2024
8bfe352
Get and pass payer email for p2p distance
neil-marcellini Mar 8, 2024
80df1b0
Merge main to try to fix typecheck
neil-marcellini Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libs/API/parameters/CreateDistanceRequestParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ type CreateDistanceRequestParams = {
billable?: boolean;
transactionThreadReportID: string;
createdReportActionIDForThread: string;
payerEmail: string;
customUnitRateID?: string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used, did you include it now so we know it's here when we need it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I could have left it out, but might as well get ready for it to be added soon.

};

export default CreateDistanceRequestParams;
2 changes: 2 additions & 0 deletions src/libs/actions/IOU.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,7 @@ function createDistanceRequest(
reportPreviewAction,
transactionThreadReportID,
createdReportActionIDForThread,
payerEmail,
onyxData,
} = getMoneyRequestInformation(
currentChatReport,
Expand Down Expand Up @@ -1081,6 +1082,7 @@ function createDistanceRequest(
billable,
transactionThreadReportID,
createdReportActionIDForThread,
payerEmail,
};

API.write(WRITE_COMMANDS.CREATE_DISTANCE_REQUEST, parameters, onyxData);
Expand Down
Loading