Fixed delete action on context menu #3803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
reviewed
Jul 1, 2021
There was a problem hiding this comment.
Left a couple comments but this is looking good to me. Requesting a review from @roryabraham as well since he reviewed the proposal
|
Updated |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
57 tasks
|
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Moving the ConfrimModal up the component tree so that it does not close with the Context Menu itself.
Fixed Issues
$ Fixes #3767
Tests | QA Steps
Tested On
Screenshots
Web
delete-w.mp4
Mobile Web
delete-m.mp4
Desktop
delete-d.mp4
iOS
Android
delete-a.mp4