-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an error Growl for failed IOU payments #3809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works, but we should add Spanish translation straight away I think.
Here is a possible advice how to get the translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Oops, haven't noticed before approving, but there is a conflict in |
resolved the merge conflict, ready for you again @mountiny |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@nickmurray47 Mmm is there a way to get the "Pay with expensify" method to appear? I tried with our expensifail accounts and was unable to see the option. |
@isagoico ah, I forgot that you need to have a "Wallet" for this option to appear. This should have been internal QA and I can QA it myself. |
passes staging QA |
Details
Send a growl to user instead of just console logging the error.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/168722
Tests / QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android