Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error Growl for failed IOU payments #3809

Merged
merged 8 commits into from
Jul 1, 2021
Merged

Conversation

nickmurray47
Copy link
Contributor

@nickmurray47 nickmurray47 commented Jun 29, 2021

Details

Send a growl to user instead of just console logging the error.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/168722

Tests / QA Steps

  1. Create an IOU between two accounts with no Expensify wallets
  2. From the payer, attempt to pay the IOU and verify an error growl appears telling you to upgrade to a GOLD wallet.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Screen Shot 2021-06-29 at 2 30 18 PM

Android

Screen Shot 2021-06-30 at 5 20 40 PM

@nickmurray47 nickmurray47 self-assigned this Jun 29, 2021
@nickmurray47 nickmurray47 requested a review from a team as a code owner June 29, 2021 21:32
@MelvinBot MelvinBot requested review from mountiny and removed request for a team June 29, 2021 21:32
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works, but we should add Spanish translation straight away I think.

Here is a possible advice how to get the translation.

@mountiny mountiny self-requested a review July 1, 2021 10:55
mountiny
mountiny previously approved these changes Jul 1, 2021
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mountiny
Copy link
Contributor

mountiny commented Jul 1, 2021

Oops, haven't noticed before approving, but there is a conflict in IOU.js file which needs to be resolved.

@nickmurray47
Copy link
Contributor Author

resolved the merge conflict, ready for you again @mountiny

Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@mountiny mountiny merged commit 5abb33c into main Jul 1, 2021
@mountiny mountiny deleted the nmurray-update-IOU-growl branch July 1, 2021 22:45
@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@isagoico
Copy link

isagoico commented Jul 8, 2021

@nickmurray47 Mmm is there a way to get the "Pay with expensify" method to appear? I tried with our expensifail accounts and was unable to see the option.

@nickmurray47
Copy link
Contributor Author

@isagoico ah, I forgot that you need to have a "Wallet" for this option to appear. This should have been internal QA and I can QA it myself.

@nickmurray47
Copy link
Contributor Author

passes staging QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants