-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on Tags page error #38096
Fix crash on Tags page error #38096
Conversation
@mkhutornyi add you as a reviewer here too since you're familiar with the flow. There are still a few inconsistencies with how we show errors for tags and other Workspace pages too, but I'll leave that for another PR. |
I tested this branch. Still crashes. Screen.Recording.2024-03-12.at.12.44.37.am.mov |
Let me check |
@mkhutornyi should be fixed now |
ok confirmed fix. Please mark as ready when ready |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Just did 😄 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb Chromemchrome.moviOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
🎯 @mkhutornyi, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #38105. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.51-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀
|
Details
Fixes a crash when renaming tag lists and also adds offline styling when toggling
requires tags
and renaming a litFixed Issues
$ #37755 (comment)
Tests
workspace/<policyID>/tags
Settings
and rename a tag list twiceOffline tests
Covered above
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
web.mov
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop