[NO QA] Update iOS AdHoc profiles to enable cplus device testing #38122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertjchen
approved these changes
Mar 12, 2024
|
We can ignore the checklists |
|
@robertjchen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
not an emergency since no QA/testing checklist is required here |
Actually we need this to get deployed to staging and then prod, should just take a couple of days |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
84 tasks
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 1.4.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.51-3 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
iOS AdHoc builds are untestable for a member of our C+ team, this change helps with PR testing.
@dukenv0307 builds generated after this gets merged should let you install to your iPhone.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/377924
Tests
MAKE SURE I DIDN'T COMMIT THE UNSIGNED PROFILES (steps)