-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: implement accounting page #38283
Feat: implement accounting page #38283
Conversation
@hayata-suenaga I'm able to access this, but can't find the accounting connection options. |
Ah sorry about that. You have to be on the beta for the accounting feature. Could you DM me on Slack the email address you use for the test account so that I can add it to the beta list? |
this is done now @hayata-suenaga |
My apologies guys. I closed this PR by accident, can we continue review here: #39652 |
Details
Implement a new page called "Accounting page" for the QuickBooks Online (QBO) connection project.
Fixed Issues
$ 37706
PROPOSAL: issue Description
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
MacOS: Chrome / Safari
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Desktop