Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto open keyboard on Password and Payment pages #3839

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

luacmartins
Copy link
Contributor

cc @chiragsalian

Fixed Issues

$ #3386

Tests

  1. Open the app and login.
  2. Go to Settings > Profile > Add Phone Number
  3. Verify that the keyboard opens automatically.
  4. Repeat step 3 in Settings > Change Password and Settings > Payments

QA Steps

  1. Open the app and login.
  2. Go to Settings > Profile > Add Phone Number
  3. Verify that the keyboard opens automatically.
  4. Repeat step 3 in Settings > Change Password and Settings > Payments

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Mobile Web

mobile-web.mov

iOS

ios.mov

Android

android.mov

@luacmartins luacmartins requested a review from a team June 30, 2021 19:10
@luacmartins luacmartins self-assigned this Jun 30, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 30, 2021 19:10
Copy link
Contributor

@MonilBhavsar MonilBhavsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
similar to secondary login page

@MonilBhavsar MonilBhavsar merged commit 999d374 into main Jul 1, 2021
@MonilBhavsar MonilBhavsar deleted the cmartins-keyboard-auto-open branch July 1, 2021 16:49
@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants