Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video replay issue in iOS #38419

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Fix video replay issue in iOS #38419

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d494a03
Fix video replay issue in iOS
ShridharGoel Mar 15, 2024
338d3bf
Disable ESlint exhaustive deps since isPlaying shouldn't be a dependency
ShridharGoel Apr 2, 2024
6d5cf81
Merge branch 'main' of https://github.com/Expensify/App into patch-2
ShridharGoel Apr 2, 2024
76719bb
Merge branch 'main' of https://github.com/Expensify/App into patch-2
ShridharGoel Apr 2, 2024
aa15e02
Add comment for exhaustive dependencies ESlint skipping
ShridharGoel Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/VideoPlayer/BaseVideoPlayer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ function BaseVideoPlayer({
const currentDuration = e.durationMillis || videoDuration * 1000;
const currentPositon = e.positionMillis || 0;

if (shouldReplayVideo(e, isVideoPlaying, currentDuration, currentPositon)) {
if (shouldReplayVideo(e, isPlaying, currentDuration, currentPositon)) {
videoPlayerRef.current.setStatusAsync({positionMillis: 0, shouldPlay: true});
}

Expand All @@ -127,6 +127,7 @@ function BaseVideoPlayer({
videoStateRef.current = e;
onPlaybackStatusUpdate(e);
},
// eslint-disable-next-line react-hooks/exhaustive-deps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment explaining why we're not adding all the deps?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

[onPlaybackStatusUpdate, preventPausingWhenExitingFullscreen, videoDuration],
);

Expand Down
Loading