fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443

Krishna2323 · 2024-03-16T20:43:52Z

Details

Fixed Issues

$ #38262
PROPOSAL: #38262 (comment)

Tests

Log in as an admin of a paid policy group and open the workspace categories settings.
Go Offline
Click on any category.
Toggle the Enable category switch.
Verify that the updated category is greyed out
Open the workspace tags settings of the same policy or any paid policy group.
Go Offline
Click on any tag.
Toggle the Enable tag switch.
Verify that the updated tag is greyed out

Verify that no errors appear in the JS console

Offline tests

Log in as an admin of a paid policy group and open the workspace categories settings.
Go Offline
Click on any category.
Toggle the Enable category switch.
Verify that the updated category is greyed out
Open the workspace tags settings of the same policy or any paid policy group.
Go Offline
Click on any tag.
Toggle the Enable tag switch.
Verify that the updated tag is greyed out

QA Steps

Log in as an admin of a paid policy group and open the workspace categories settings.
Go Offline
Click on any category.
Toggle the Enable category switch.
Verify that the updated category is greyed out
Open the workspace tags settings of the same policy or any paid policy group.
Go Offline
Click on any tag.
Toggle the Enable tag switch.
Verify that the updated tag is greyed out

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

… offline. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

melvin-bot · 2024-03-16T20:43:57Z

@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2024-03-17T12:01:00Z

Tags have already been fixed. @Krishna2323 you might want to update the PR title.

Krishna2323 · 2024-03-17T13:14:35Z

@allroundexperts, do you have link which pr/commit fixed it? I don't think it has been fixed.

allroundexperts · 2024-03-17T13:16:28Z

#38332

Krishna2323 · 2024-03-17T13:17:50Z

@cubuspl42, do you prefer adding pendingAction field or should we do it like Object.values(value.pendingFields ?? {}).length > 0. I asked because we can update multiple things in tag/category and pendingFields is always updated, we might miss pendingAction when we update other thing in tag/category.

Edit: we can use Object.values(value.pendingFields ?? {}).length > 0 with || condition. I think thats a better option.

pendingAction: value.pendingAction || Object.values(value.pendingFields ?? {}).length > 0

Krishna2323 · 2024-03-17T13:23:47Z

@allroundexperts, I think you misunderstood this issue, its about the tags/categories not being greyed out when updated.

allroundexperts · 2024-03-17T13:34:44Z

Ah gotcha. False ⏰

cubuspl42 · 2024-03-18T11:16:22Z

@cubuspl42, do you prefer adding pendingAction field or should we do it like Object.values(value.pendingFields ?? {}).length > 0. I asked because we can update multiple things in tag/category and pendingFields is always updated, we might miss pendingAction when we update other thing in tag/category.

Edit: we can use Object.values(value.pendingFields ?? {}).length > 0 with || condition. I think thats a better option.
pendingAction: value.pendingAction || Object.values(value.pendingFields ?? {}).length > 0

Uuhh, I'm... not sure. Are you saying you found a bug/undesired behavior in your solution? Or are you asking me to confirm whether the scenario is actually a bug?

If you are sure that you found a bug/undesired behavior, fix it. It's easiest to discuss the code in the "Files changed" view, after it's actually written.

If you're unsure about how to classify this scenario and ask for help in this aspect, please provide more specific reproduction steps, similarly as we do in the "Tests" steps.

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 · 2024-03-18T21:54:47Z

sorry @cubuspl42, I asked this question in #38443 (comment), you can ignore.

cubuspl42 · 2024-03-19T10:30:00Z

src/pages/workspace/tags/WorkspaceTagsPage.tsx

-                                        src={Expensicons.ArrowRight}
-                                        fill={theme.icon}
-                                    />
+                    Object.values(policyTagList.tags || []).map((value) => {


I know we only update this function, but as we touch these lines, let's change the name value to tag or policyTag

cubuspl42 · 2024-03-19T11:05:53Z

@Krishna2323

could you however align the tags behaviour with categories in your PR please? Thank you

Is this request done?

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

cubuspl42 · 2024-03-20T10:18:33Z

Is this request done?

Bump on the question 🙂 I just want to confirm whether what Vit asked for is already taken care of.

Krishna2323 · 2024-03-20T10:29:54Z

@cubuspl42, sorry for delay, I'm currently looking at that, it seems like it has been fixed on the main. We can just move forward with what we currently have. I'm adding recordings.

Krishna2323 · 2024-03-20T12:24:26Z

@cubuspl42, I'm facing a weird issue on android simulator, it always stays offline. Do you have any suggestions? I tried creating different versions/models.

cubuspl42 · 2024-03-20T12:35:47Z

Cold booting sometimes helps, but if freshly created virtual devices are offline, then I'm not sure 🤔

Krishna2323 · 2024-03-20T12:37:58Z

@cubuspl42, thanks for looking into that, seems like there was an issue with the hotel's wifi, it got fixed when I connected to my mobile's wifi.

Krishna2323 · 2024-03-20T13:29:07Z

@cubuspl42 recordings added.

cubuspl42 · 2024-03-21T10:42:49Z

Is it expected that I can't open the category/tag details while the UI element is grayed out?

Edit: Not expected.

Krishna2323 · 2024-03-25T11:57:46Z

@cubuspl42, can you pls review if you have sometime, we don't need to make any further changes? Thanks

cubuspl42 · 2024-03-25T15:55:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

categories-gray-out-android-compressed.mp4

Android: mWeb Chrome

categories-gray-out-android-web-compressed.mp4

iOS: Native

categories-gray-out-ios-compressed.mp4

iOS: mWeb Safari

categories-gray-out-ios-web-compressed.mp4

MacOS: Chrome / Safari

categories-gray-out-web-converted.mp4

MacOS: Desktop

mountiny

Thanks!

OSBotify · 2024-03-25T22:03:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

fix: Categories & Tags - Row is not grayed out entirely when disabled…

f508bc9

… offline. Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner March 16, 2024 20:43

melvin-bot bot removed the request for review from a team March 16, 2024 20:43

melvin-bot bot requested a review from cubuspl42 March 16, 2024 20:43

Merge branch 'Expensify:main' into krishna2323/issue/38262

c10cd5e

Krishna2323 mentioned this pull request Mar 18, 2024

[HOLD for payment 2024-04-05] [$250] [Categories] - Category row is not grayed out entirely when disabled offline #38262

Closed

6 tasks

Krishna2323 added 2 commits March 19, 2024 02:30

Merge branch 'Expensify:main' into krishna2323/issue/38262

8f57f13

disable tag selection when pending action.

75e87f3

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

cubuspl42 suggested changes Mar 19, 2024

View reviewed changes

Krishna2323 added 2 commits March 20, 2024 15:37

clear selected tag on navigating to tag settings.

8b31c5e

Signed-off-by: Krishna Gupta <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/38262

f602304

Krishna2323 mentioned this pull request Mar 20, 2024

[HOLD for payment 2024-04-05] [$250] [Simplified Collect][Tags] - Deleted tag can be clicked on when deleted offline #38663

Closed

6 tasks

mountiny assigned Krishna2323 Mar 25, 2024

cubuspl42 approved these changes Mar 25, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny March 25, 2024 15:56

mountiny approved these changes Mar 25, 2024

View reviewed changes

mountiny merged commit 1b0fe6d into Expensify:main Mar 25, 2024
16 of 17 checks passed

github-actions bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443

fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443

Krishna2323 commented Mar 16, 2024 •

edited

Loading

melvin-bot bot commented Mar 16, 2024

allroundexperts commented Mar 17, 2024

Krishna2323 commented Mar 17, 2024

allroundexperts commented Mar 17, 2024

Krishna2323 commented Mar 17, 2024 •

edited

Loading

Krishna2323 commented Mar 17, 2024

allroundexperts commented Mar 17, 2024

cubuspl42 commented Mar 18, 2024

Krishna2323 commented Mar 18, 2024

cubuspl42 Mar 19, 2024

cubuspl42 commented Mar 19, 2024

cubuspl42 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

cubuspl42 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

cubuspl42 commented Mar 21, 2024 •

edited

Loading

Krishna2323 commented Mar 25, 2024

cubuspl42 commented Mar 25, 2024

mountiny left a comment

OSBotify commented Mar 25, 2024

fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443

fix: Categories & Tags - Row is not grayed out entirely when disabled offline. #38443

Conversation

Krishna2323 commented Mar 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 16, 2024

allroundexperts commented Mar 17, 2024

Krishna2323 commented Mar 17, 2024

allroundexperts commented Mar 17, 2024

Krishna2323 commented Mar 17, 2024 • edited Loading

Krishna2323 commented Mar 17, 2024

allroundexperts commented Mar 17, 2024

cubuspl42 commented Mar 18, 2024

Krishna2323 commented Mar 18, 2024

cubuspl42 Mar 19, 2024

Choose a reason for hiding this comment

cubuspl42 commented Mar 19, 2024

cubuspl42 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

cubuspl42 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

Krishna2323 commented Mar 20, 2024

cubuspl42 commented Mar 21, 2024 • edited Loading

Krishna2323 commented Mar 25, 2024

cubuspl42 commented Mar 25, 2024

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 25, 2024

Krishna2323 commented Mar 16, 2024 •

edited

Loading

Krishna2323 commented Mar 17, 2024 •

edited

Loading

cubuspl42 commented Mar 21, 2024 •

edited

Loading