-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use left/right arrow keys to move cursor in IOUAmountPage #3850
Use left/right arrow keys to move cursor in IOUAmountPage #3850
Conversation
Appreciate you calling this out! I can test on desktop 🙂 |
@rushatgabhane Can you also be sure to test and include screenshots for mobile web and android? I will test on iOS and desktop for you 😄 |
Thanks, really appreciate it! |
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes! Great work!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
cc @roryabraham
Details
Replace
onKeyPress
prop withonChangeText
prop and handle the amount changed.Also, rename
updateAmountIfValidInput()
toupdateAmountNumberPad()
, and Remove check forBackspace
.Because it updates amount only for numpad now.
Fixed Issues
$ #3779
Tests / QA
Tested On
Don't have mac to test desktop app.
Screenshots
Web
NEW.Expensify.cash.-.Google.Chrome.2021-06-29.03-11-09.mp4
Android
Mobile Web
Desktop
iOS