-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the height of Edit profile button #3854
Conversation
@shawnborton Hi! Would you be able to double check the design here. From the issue, I was not sure if we should update the height of the button on all platforms or only website/desktop. Thank you for feedback! |
Out of curiosity, what font size do small buttons use? |
I agree this should be a global change and not platform specific (as are most of the things we do with E.cash!) |
Ok, so on the screenshots, the text is size 15px, because the styles were no applied on correct component. So for comparison, this is and this is the actual buttonSmallText Let me know which one I should use :) |
Perfect! Yes - the smaller button size should use the smaller font size as well. |
Thank you Shawn! Updated it and also the screenshots in the description. @HorusGoul It is good for a review 🙏 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
Details
This PR is adding a
small
option to Button component (styles already exist) and updates theEdit profile
button in Profile part of Settings to be 28px tall instead of 40px.Fixed Issues
$ #2434
Tests
Edit profile
button is 28px tallQA Steps
Same as testing except of visiting staging or production version of the app.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android