Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed scrolling issue #3856

Merged
merged 1 commit into from
Jul 2, 2021
Merged

fixed scrolling issue #3856

merged 1 commit into from
Jul 2, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 1, 2021 •
edited
Loading

Details

Fixed Issues

$ Fixes #3768
Fixes #3781

Tests | QA Steps

Fab button issue testing:

  1. Open e.cash in mWeb
  2. Click + fab button on LHN.
  3. It should open properly. See issue mweb - Tapping green fab does not open the menu docking to the bottom #3768 for more info.

Horizontal scroll issue:

  1. Open E.cash Mobile web.
  2. Open any chat.
  3. Close the chat, go back to the home page or LHN.
  4. Try to scroll the page horizontally.
  5. Page should not scroll and you should click on any chat to open it. Please check the linked video on issue LHN can be scrolled horizontally while closed. #3781 to see the absurd scrolling behavior.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

fix-scroll.mp4

Desktop

scroll-d

iOS

scroll-i

Android

scroll-a

@parasharrajat parasharrajat marked this pull request as ready for review July 1, 2021 21:50
@parasharrajat parasharrajat requested a review from a team as a code owner July 1, 2021 21:50
@MelvinBot MelvinBot requested review from Luke9389 and removed request for a team July 1, 2021 21:50
@parasharrajat
Copy link
Member Author

This is a quick one. Thanks

@parasharrajat parasharrajat mentioned this pull request Jul 1, 2021
Closed
@Beamanator Beamanator self-requested a review July 2, 2021 12:57
Beamanator
Beamanator approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both issues, this fixes both - nice work!

@Beamanator Beamanator merged commit 824e85f into Expensify:main Jul 2, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 7, 2021
Closed
57 tasks
@isagoico
Copy link

isagoico commented Jul 8, 2021

@parasharrajat Anything that needs to be QAd here?

@parasharrajat
Copy link
Member Author

@isagoico Somehow tests got removed. I have re-added them. Thanks.

@parasharrajat parasharrajat deleted the scrolling branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

@Luke9389 Luke9389 Awaiting requested review from Luke9389

Assignees

@parasharrajat parasharrajat

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@parasharrajat @OSBotify @isagoico @Beamanator