Setup the new Send Money page and header titles #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickmurray47
changed the title
added 2 commits
July 1, 2021 16:54
nickmurray47
changed the title
nickmurray47
changed the title
MariaHCD
approved these changes
Jul 2, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
57 tasks
|
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
Beamanator
reviewed
Jul 15, 2021
| @@ -136,6 +136,7 @@ export default { | |||
| confirm: 'Confirm', | |||
| splitBill: 'Split Bill', | |||
| requestMoney: 'Request Money', | |||
| sendMoney: 'Send Money', | |||
There was a problem hiding this comment.
Creepin' on your PR :D Did you mean to also add a translation in es.js?
There was a problem hiding this comment.
Was planning on adding all the translations in one big translation PR at the end!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Adds the Send Money Page container and updates the header title steps to reflect the new flow
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/169170
$ https://github.com/Expensify/Expensify/issues/169174
Tests
/iou/send/{currentChatReportID}, e.g./iou/send/182. Verify this opens up a new IOU Send modal.QA Steps
Same as above. Will also test the full flow once the payment and DM/Global Create menu's are hooked up.
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android