-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Onboarding - Stage 1] Onboarding Flow - enabled #38753
[Onboarding - Stage 1] Onboarding Flow - enabled #38753
Conversation
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
@hoangzinh is going to take the C+ on this as the next step to #37733 |
…d-on merge wave9/onboarding-flow into wave9/onboarding-flow-turned-on
This is off hold now 🎉 |
Nice, I think we need to pull main and adjust some of the style changes here that are no longer needed? |
@filip-solecki please remove in TestToolMenu as well App/src/components/TestToolMenu.tsx Lines 93 to 103 in 13b0974
|
@hoangzinh I know, it is not ready yet |
Closing in favour of #39687 |
HELD on #37733
Details
This PR enables Stage 1 Onboarding Flow. It should be merged after #37733 is approved and merged.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/351581
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop