Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e-common dependency #3878

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Update e-common dependency #3878

merged 1 commit into from
Jul 3, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Jul 3, 2021 •
edited
Loading

Please review @Jag96

Details

Fixed Issues

$ fixes #2846

Tests | QA Steps

  1. Navigate to a conversation
  2. Send this text
~ I am not striked~ but ~I am~. Neither ~ this ~ one nor ~this ~.
_ I am not italic_ but _I am_. Neither _ this _ one nor _this _.
* I am not bold* but *I am*. Neither * this * one nor *this *.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

iOS

Android

Screenshot 2021-07-03 05:58:00

@parasharrajat parasharrajat requested a review from a team as a code owner July 3, 2021 00:15
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team July 3, 2021 00:15
Jag96
Jag96 approved these changes Jul 3, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit 079c12b into Expensify:main Jul 3, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 3, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 7, 2021
Closed
57 tasks
@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

@parasharrajat parasharrajat deleted the url-fix branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@puneetlath puneetlath Awaiting requested review from puneetlath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strikethrough text is not working as expected if there's a space before the ~
4 participants
@parasharrajat @OSBotify @roryabraham @Jag96