Fix URL routing for IOU #3888
Fix URL routing for IOU #3888
Conversation
| IOU_REQUEST, | ||
| IOU_BILL, | ||
| IOU_SEND, | ||
| IOU_REQUEST_WITH_REPORT_ID: `${IOU_REQUEST}/:reportID?`, | ||
| IOU_BILL_WITH_REPORTID: `${IOU_BILL}/:reportID?`, | ||
| IOU_SEND_WITH_REPORTID: `${IOU_SEND}/:reportID?`, | ||
| getIouRequestRoute: reportID => `${IOU_REQUEST}/${reportID}`, | ||
| getIouSplitRoute: reportID => `${IOU_BILL}/${reportID}`, | ||
| getIOUSendRoute: reportID => `${IOU_SEND}/${reportID}`, | ||
| IOU_BILL_CURRENCY: `${IOU_BILL}/:reportID/currency`, | ||
| IOU_REQUEST_CURRENCY: `${IOU_REQUEST}/:reportID/currency`, | ||
| IOU_SEND_CURRENCY: `${IOU_SEND}/:reportID/currency`, | ||
| getIouRequestCurrencyRoute: reportID => `${IOU_REQUEST}/${reportID}/currency`, | ||
| getIouBillCurrencyRoute: reportID => `${IOU_BILL}/${reportID}/currency`, | ||
| getIouSendCurrencyRoute: reportID => `${IOU_SEND}/${reportID}/currency`, | ||
| IOU_DETAILS, | ||
| IOU_DETAILS_WITH_IOU_REPORT_ID: `${IOU_DETAILS}/:chatReportID/:iouReportID/`, |
There was a problem hiding this comment.
NAB: Have we defined a pattern for how we want to organize these routes? It seems like they're grouped by the pages they're related to. I personally think it's more clear if the getter for a route is placed right after the route itself.
This might be a good opportunity to define a clearer way to organize routes since this list is only going to get longer and longer.
There was a problem hiding this comment.
I personally think it's more clear if the getter for a route is placed right after the route itself.
I tried to reorganize things in a way that made sense to me, but definitely prioritizing the bug fix over the engineering efficiency of having things in a certain order. 😄
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday. |
cc @Julesssss
Details
Fixed Issues
$ #3886
Tests
QA Steps
%3AreportIDis shown in the URLTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android