Validate different phone number formats #38993

tienifr · 2024-03-26T11:24:05Z

Details

expensify-common's isValidPhone only validates E.164 format numbers. We need to:

Rename isValidPhone to isValidE164Phone and add a new function isValidPhone to validate phone numbers in general in Validate phone numbers in different formats expensify-common#672
Change their usages in App accordingly in this PR

significant: 4404589784
international: +1 440-458-9784
e164: +14404589784
national: (440) 458-9784
123.456.7890

Fixed Issues

$ #37723
PROPOSAL: #37723 (comment)

Tests

Go to Workspace > Bank account.
Initiate the add BA flow
Proceed to Company's phone number step
Enter a random US number in national format (xxx) xxx-xxxx, e.g., "(440) 458-9784"
Press Next
Verify that the phone number is parsed successfully

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Go to Workspace > Bank account.
Initiate the add BA flow
Proceed to Company's phone number step
Enter a random US number in national format (xxx) xxx-xxxx, e.g., "(440) 458-9784"
Press Next
Verify that the phone number is parsed successfully

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-26.at.18.48.35-compressed.mov

Android: mWeb Chrome

Screen.Recording.2024-03-26.at.18.46.27-compressed.mov

iOS: Native

Screen.Recording.2024-03-26.at.18.47.34-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-03-26.at.18.49.05-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-26.at.18.32.42-compressed.mov

MacOS: Desktop

Screen.Recording.2024-03-26.at.18.32.42-compressed.mov

melvin-bot · 2024-03-26T11:49:55Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dragnoir · 2024-03-26T19:44:12Z

done some tests

+1 800-123-4567: ✅ Valid
800-123-4567: ✅ Valid
800.123.4567: ✅ Valid
(800) 123-4567: ✅ Valid
+44 123 456 7890: ✅ Valid
020 3000 5555: ❌ Invalid
0451 234 567: ❌ Invalid
+61 451 234 567: ❌ Invalid
+49151 23456789: ✅ Valid
151-23456789: ✅ Valid
030 98765432: ✅ Valid
+1 (800) 123.4567: ✅ Valid
invalid number: ❌ Invalid
+123 456 789 0123: ❌ Invalid

src/CONST.ts

Pujan92 · 2024-04-02T14:20:04Z

@tienifr Need to resolve conflicts

tienifr · 2024-04-02T15:22:37Z

@Pujan92 All done.

Pujan92 · 2024-04-02T16:01:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

andt2.webm

Android: mWeb Chrome

andt1.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-02.at.21.44.40.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-02.at.21.37.53.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-02.at.21.29.08.mov

MacOS: Desktop

Screen.Recording.2024-04-02.at.21.47.43.mov

Pujan92 · 2024-04-02T16:24:28Z

Performance Tests are failing, @tienifr can you merge the main again.

Pujan92

LGTM, Thanks :)

Pujan92 · 2024-04-03T12:14:18Z

@tienifr Seeing conflicts again

tienifr · 2024-04-03T13:24:08Z

@Pujan92 Thanks, updated!

Pujan92 · 2024-04-03T14:37:10Z

Bump @grgia in case you missed this.

grgia · 2024-04-03T14:38:59Z

Thank you @tienifr @Pujan92

OSBotify · 2024-04-03T14:45:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-08T10:55:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 3 commits March 26, 2024 18:18

validate different phone number formats

9fea532

fix lint

25e0479

fix lint

4947944

tienifr marked this pull request as ready for review March 26, 2024 11:49

tienifr requested a review from a team as a code owner March 26, 2024 11:49

melvin-bot bot removed the request for review from a team March 26, 2024 11:49

melvin-bot bot requested a review from Pujan92 March 26, 2024 11:49

tienifr mentioned this pull request Mar 26, 2024

[HOLD for payment 2024-04-15] [$500] BA - On the phone number page, user can not enter data as the placeholder shows #37723

Closed

6 tasks

tienifr added 2 commits March 27, 2024 17:53

Merge branch 'main' of https://github.com/tienifr/App into fix/37723

b37294b

Bump expensify-common version

8bb3c29

Pujan92 reviewed Mar 27, 2024

View reviewed changes

src/CONST.ts Outdated Show resolved Hide resolved

tienifr added 3 commits March 29, 2024 02:26

remove redundant change

b017ce6

Merge branch 'main' into fix/37723

e66bbc0

Bump expensify-common version

c47ccff

Pujan92 mentioned this pull request Mar 29, 2024

Validate phone numbers in different formats Expensify/expensify-common#672

Merged

tienifr added 2 commits April 1, 2024 16:44

Merge branch 'main' of https://github.com/tienifr/App into fix/37723

ead00a5

Bump expensify-common version

b052559

tienifr added 2 commits April 2, 2024 22:21

Merge branch 'main' into fix/37723

c63a474

Bump expensify-common version

139c880

Merge branch 'main' of https://github.com/tienifr/App into fix/37723

59c97cf

Pujan92 approved these changes Apr 2, 2024

View reviewed changes

melvin-bot bot requested a review from grgia April 2, 2024 18:16

Merge branch 'main' into fix/37723

467b1b0

grgia approved these changes Apr 3, 2024

View reviewed changes

grgia merged commit 7177173 into Expensify:main Apr 3, 2024
15 checks passed

github-actions bot mentioned this pull request Apr 4, 2024

[INCORRECT] (used to be a checklist but was incorrectly triggered) #39573

Closed

44 tasks

mountiny mentioned this pull request Apr 4, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

Pujan92 mentioned this pull request Apr 4, 2024

Bump expensify-common #37723 #39634

Merged

59 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Validate different phone number formats #38993

Validate different phone number formats #38993

tienifr commented Mar 26, 2024 •

edited

Loading

melvin-bot bot commented Mar 26, 2024

dragnoir commented Mar 26, 2024

Pujan92 commented Apr 2, 2024

tienifr commented Apr 2, 2024

Pujan92 commented Apr 2, 2024 •

edited

Loading

Pujan92 commented Apr 2, 2024

Pujan92 left a comment

Pujan92 commented Apr 3, 2024

tienifr commented Apr 3, 2024

Pujan92 commented Apr 3, 2024

grgia commented Apr 3, 2024

OSBotify commented Apr 3, 2024

OSBotify commented Apr 8, 2024

Validate different phone number formats #38993

Validate different phone number formats #38993

Conversation

tienifr commented Mar 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 26, 2024

dragnoir commented Mar 26, 2024

Pujan92 commented Apr 2, 2024

tienifr commented Apr 2, 2024

Pujan92 commented Apr 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Pujan92 commented Apr 2, 2024

Pujan92 left a comment

Choose a reason for hiding this comment

Pujan92 commented Apr 3, 2024

tienifr commented Apr 3, 2024

Pujan92 commented Apr 3, 2024

grgia commented Apr 3, 2024

OSBotify commented Apr 3, 2024

OSBotify commented Apr 8, 2024

tienifr commented Mar 26, 2024 •

edited

Loading

Pujan92 commented Apr 2, 2024 •

edited

Loading