Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add version to mergedPR logs #3909

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Conversation

roryabraham
Copy link
Contributor

Details

Still trying to diagnose what is going wrong with the createOrUpdateStagingDeploy action. I can see from the existing logs what is going wrong, but I have no idea why. For example, in this action run, we can see:

  1. That the NPM_VERSION input is being passed and parsed correctly.

  2. That the tag of the previous StagingDeployCash is being correctly parsed.

  3. That running GitUtils.getPullRequestsMergedBetween locally with the correct previous + new tag produces very different results than we're seeing in the action:

    image

  4. That, when running this locally, switching the order of the tags doesn't even seem to matter:

    image

Fixed Issues

$ n/a

Tests

Merge this PR and look at the logs of the createOrUpdateStagingDeploy action that results.

Platforms

GitHub only.

@roryabraham roryabraham requested a review from Jag96 July 7, 2021 22:24
@roryabraham roryabraham requested a review from a team as a code owner July 7, 2021 22:24
@roryabraham roryabraham self-assigned this Jul 7, 2021
@MelvinBot MelvinBot requested review from Dal-Papa and removed request for a team July 7, 2021 22:24
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, skipping unnecessary tests to speed up testing

@Jag96 Jag96 merged commit bcbbda0 into main Jul 7, 2021
@Jag96 Jag96 deleted the Rory-ImproveLogsOfStagingDeployCash branch July 7, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants