Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add logs directly inside GetPRsMergedBetween #3913

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

roryabraham
Copy link
Contributor

Details

Still trying to figure out how createOrUpdateStagingDeploy is broken. It seems as though the correct inputs are being passed to GitUtils.getPullRequestsMergedBetween, but it's producing the wrong outputs. So the only next step for now is to log what's happening within that function.

Fixed Issues

$ n/a

Tests

Merge this PR and see what happens.

Platforms

GitHub only.

@roryabraham roryabraham requested a review from Jag96 July 7, 2021 23:17
@roryabraham roryabraham self-assigned this Jul 7, 2021
@roryabraham roryabraham requested a review from a team as a code owner July 7, 2021 23:17
@MelvinBot MelvinBot requested review from jasperhuangg and removed request for a team July 7, 2021 23:17
Jag96
Jag96 previously approved these changes Jul 7, 2021
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, skipping unnecessary tests

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit dd90800 into main Jul 7, 2021
@Jag96 Jag96 deleted the Rory-LogGetPRsMergedBetween branch July 7, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants