Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new HOC to get
policy.connections
data #39132Add new HOC to get
policy.connections
data #39132Changes from 4 commits
06e5ea4
c945585
e0532d5
e6292e3
b509d0f
8e32fde
d8139a8
9a44aeb
cf2cce6
2370278
db3252e
0eca9cd
b7ab9e0
1b09ba0
32e979b
6f5d49b
14c8e92
357ce25
d9340cf
68db14d
4ba46b9
2254f3e
b1272d4
d29646d
124f534
c1e0cac
515833e
f21307a
a44ab1c
170cf3a
f25a3e5
31cd1ec
9457554
c4593e7
4804fd1
e19060b
a084e52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why we return nothing if the
connections
are false, I try to use it on the workspace profile page but it shows a blank page. Also, I'm curious about what case the HOC will be used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments in the new commit. It explains the usage of the HOC and the context that I also added in that commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mollfpr, @aldo-expensify, should we return
LoadingPage
instead ofnull
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might be able to leverage this later. The only case I think we should return
null
is where we want to navigate the page if there are noconnections
to avoid rendering a component while animating the transition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should should a spinner if
policy.isLoadingConnections
is true, and ifpolicy.isLoadingConnections
is false, hmmm 404? 🤷