Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix created action is duplicate when assigning a task #39152

Merged
merged 4 commits into from
Mar 29, 2024
Merged

Fix created action is duplicate when assigning a task #39152

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abb5ce3
Fix created action is duplicate when assigning a task
nkdengineer Mar 28, 2024
14dbcd1
fallback isOptimisticReport
nkdengineer Mar 28, 2024
02399e3
add explain comment
nkdengineer Mar 29, 2024
d8abbe2
Update src/libs/actions/Task.ts
nkdengineer Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/libs/actions/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,14 @@ function setAssigneeValue(
Onyx.merge(ONYXKEYS.PERSONAL_DETAILS_LIST, {[assigneeAccountID]: optimisticPersonalDetailsListAction});
}

setAssigneeChatReport(report);
// The optimistic field may not exist in the existing report and it can be overridden by the optimistic field of previous report data when merging the assignee chat report
// So we should add these optimistic fields here to prevent merging incorrectly which can lead to creating duplicate created actions for an existing report
nkdengineer marked this conversation as resolved.
Show resolved Hide resolved
setAssigneeChatReport({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an comment to explain why have this change? Thank you 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hungvu193 I updated.

...report,
isOptimisticReport: report?.isOptimisticReport ?? false,
pendingFields: report?.pendingFields,
pendingAction: report?.pendingAction,
});

// If there is no share destination set, automatically set it to the assignee chat report
// This allows for a much quicker process when creating a new task and is likely the desired share destination most times
Expand Down
Loading