[NoQA] feat: more startup marks #39181

kirillzyusko · 2024-03-28T14:19:01Z

Details

Capture new metrics:

appCreation
nativeLaunchEnd_To_appCreationStart
appCreationEnd_To_contentAppeared
contentAppeared_To_screenTTI

A sequence of all events is shown in this diagram (credits to @hurali97)

To verify that metrics are calculated properly we can use next equation:

TTI = nativeLaunch + nativeLaunchEnd_To_appCreationStart + appCreation + appCreationEnd_To_contentAppeared + contentAppeared_To_screenTTI

An example of metrics:

Debug

{
  'App start nativeLaunch': [
    614, 605, 620, 601, 632,
    613, 623, 655, 651, 655,
    646, 670, 656, 684, 686,
    730, 691
  ],
  'App start appCreation': [
    226, 200, 226, 189, 212,
    206, 212, 209, 239, 247,
    215, 206, 253, 210, 215,
    233, 257
  ],
  'App start contentAppeared_To_screenTTI': [
    2297.5213369727135, 2147.9439079761505,
    2096.1065099835396, 2204.7391229867935,
     2215.209748983383, 2164.7248899936676,
     2364.765137016773, 2379.7745000123978,
     2363.229461014271, 2377.0611709952354,
    2460.2801690101624, 2350.8586649894714,
     2364.095607995987,  2416.493358016014,
    2559.1686559915543, 2440.7956550121307,
    2477.9847869873047
  ],
  'App start appCreationEnd_To_contentAppeared': [
    4830, 5069, 4998, 4905,
    5014, 4927, 5027, 5273,
    5267, 5159, 5250, 5267,
    5287, 5386, 5674, 5651,
    5597
  ],
  'App start nativeLaunchEnd_To_appCreationStart': [
    155, 156, 138, 155, 162,
    147, 154, 161, 165, 144,
    154, 147, 160, 156, 163,
    159, 150
  ],
  'App start jsBundleDownload': [
    1032, 1106, 1107, 1050,
    1083, 1068, 1119, 1016,
    1063, 1107, 1071, 1115,
    1067, 1044, 1078, 1101,
    1094
  ],
  'App start runJsBundle': [
    3325, 3413, 3306, 3320,
    3390, 3347, 3434, 3617,
    3581, 3498, 3652, 3600,
    3641, 3763, 4030, 3945,
    3896
  ],
  'App start TTI': [
    8122.5213369727135, 8177.9439079761505,
      8078.10650998354, 8054.7391229867935,
     8235.209748983383,  8057.724889993668,
     8380.765137016773,  8677.774500012398,
      8685.22946101427,  8582.061170995235,
     8725.280169010162,  8640.858664989471,
     8720.095607995987,  8852.493358016014,
     9297.168655991554,   9213.79565501213,
     9172.984786987305
  ],
  'App start regularAppStart': [
     0.4095050096511841, 0.46081602573394775,
    0.48258501291275024,  0.3986409902572632,
    0.39428699016571045, 0.40445899963378906,
     0.4330649971961975, 0.46696001291275024,
     0.4245610237121582, 0.43420398235321045,
     0.4852699637413025, 0.45882201194763184,
    0.43571001291275024,  0.4542649984359741,
    0.49698901176452637, 0.45845603942871094,
     0.4975999593734741
  ]
}

Release

{
  'App start nativeLaunch': [
    77, 48, 46, 58,
    49, 51, 49, 49
  ],
  'App start nativeLaunchEnd_To_appCreationStart': [
    51, 95, 47, 62,
    51, 48, 41, 40
  ],
  'App start appCreationEnd_To_contentAppeared': [
    438, 461, 428,
    474, 420, 432,
    447, 509
  ],
  'App start contentAppeared_To_screenTTI': [
    752.8226479887962,
    729.9659600257874,
    886.4854120016098,
    844.554790019989,
    774.1200180053711,
    863.9782549738884,
    860.0640730261803,
    887.7919390201569
  ],
  'App start appCreation': [
    67, 64, 75, 68,
    76, 77, 70, 70
  ],
  'App start runJsBundle': [
    363, 380, 343,
    378, 344, 355,
    371, 422
  ],
  'App start regularAppStart': [
    0.01904296875,
    0.01757800579071045,
    0.01810699701309204,
    0.016071975231170654,
    0.016317009925842285,
    0.018310964107513428,
    0.017089009284973145,
    0.027547001838684082
  ],
  'App start TTI': [
    1385.8226479887962,
    1397.9659600257874,
    1482.4854120016098,
    1506.554790019989,
    1370.120018005371,
    1471.9782549738884,
    1467.0640730261803,
    1555.7919390201569
  ]
}

Fixed Issues

$ #35234 (comment)
PROPOSAL: #35234 (comment)

Tests

run e2e tests and gather metrics;
be sure that formula in description produces valid output.
Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

run e2e tests and gather metrics;
be sure that formula in description produces valid output.
Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-03-28T14:19:06Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-03-28T14:33:43Z

I'll be testing this in the next couple of hours

kirillzyusko · 2024-03-28T15:19:56Z

@hurali97 please also have a look on it 🙏

hungvu193 · 2024-03-28T16:52:50Z

verified that it worked 🎉

hungvu193 · 2024-03-28T18:19:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-28.at.23.50.57.mov

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

hungvu193 · 2024-03-28T18:20:13Z

@kirillzyusko Can you also tick the checkmark Verify that no errors appear in the JS console? Thank you.

kirillzyusko · 2024-03-28T18:52:34Z

Can you also tick the checkmark Verify that no errors appear in the JS console? Thank you.

Done @hungvu193 🙌

melvin-bot · 2024-03-29T00:03:50Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #35234 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

hungvu193

Test well 🎉

mountiny

LGTM, but it would be great to get @hurali97 or @adhorodyski to approve too

hurali97

LGTM ✅

OSBotify · 2024-04-02T11:42:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

hungvu193 · 2024-04-05T06:31:30Z

hey @mountiny , Can you create payment issue for this? Seems Melvin didn't auto create it.

mountiny · 2024-04-05T14:25:49Z

done

OSBotify · 2024-04-08T10:56:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

feat: more startup marks

3665025

kirillzyusko requested a review from a team as a code owner March 28, 2024 14:19

melvin-bot bot requested review from hungvu193 and removed request for a team March 28, 2024 14:19

This comment was marked as outdated.

Sign in to view

hungvu193 approved these changes Mar 29, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny March 29, 2024 00:04

mountiny approved these changes Mar 29, 2024

View reviewed changes

mountiny assigned kirillzyusko Mar 29, 2024

hurali97 approved these changes Apr 2, 2024

View reviewed changes

mountiny changed the title ~~feat: more startup marks~~ [NoQA] feat: more startup marks Apr 2, 2024

mountiny merged commit bf1ec5a into Expensify:main Apr 2, 2024
22 checks passed

github-actions bot mentioned this pull request Apr 4, 2024

[INCORRECT] (used to be a checklist but was incorrectly triggered) #39573

Closed

44 tasks

mountiny mentioned this pull request Apr 4, 2024

Deploy Checklist: New Expensify 2024-04-04 #39588

Closed

48 tasks

mountiny mentioned this pull request Apr 5, 2024

[Awaiting Payment 15th April] Payment issue for E/App PR#39181 #39719

Closed

melvin-bot bot mentioned this pull request Apr 8, 2024

[HOLD for payment 2024-04-15] [Tracking] Metric - App Startup (Performance audit by Callstack) #35234

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] feat: more startup marks #39181

[NoQA] feat: more startup marks #39181

kirillzyusko commented Mar 28, 2024 •

edited

Loading

melvin-bot bot commented Mar 28, 2024

hungvu193 commented Mar 28, 2024

kirillzyusko commented Mar 28, 2024

hungvu193 commented Mar 28, 2024

hungvu193 commented Mar 28, 2024 •

edited

Loading

hungvu193 commented Mar 28, 2024

kirillzyusko commented Mar 28, 2024

This comment was marked as outdated.

melvin-bot bot commented Mar 29, 2024

hungvu193 left a comment

mountiny left a comment

hurali97 left a comment

OSBotify commented Apr 2, 2024

hungvu193 commented Apr 5, 2024

mountiny commented Apr 5, 2024

OSBotify commented Apr 8, 2024

[NoQA] feat: more startup marks #39181

[NoQA] feat: more startup marks #39181

Conversation

kirillzyusko commented Mar 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 28, 2024

hungvu193 commented Mar 28, 2024

kirillzyusko commented Mar 28, 2024

hungvu193 commented Mar 28, 2024

hungvu193 commented Mar 28, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 commented Mar 28, 2024

kirillzyusko commented Mar 28, 2024

This comment was marked as outdated.

melvin-bot bot commented Mar 29, 2024

hungvu193 left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

hurali97 left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 2, 2024

hungvu193 commented Apr 5, 2024

mountiny commented Apr 5, 2024

OSBotify commented Apr 8, 2024

kirillzyusko commented Mar 28, 2024 •

edited

Loading

hungvu193 commented Mar 28, 2024 •

edited

Loading