Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Ensure we don't show optimistic preview action for one-transaction reports #39433

Merged
merged 2 commits into from
Apr 2, 2024
Merged

[CP Staging] Ensure we don't show optimistic preview action for one-transaction reports #39433

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df53dc9
ensure we don't show optimistic preview action for one-transaction re…
NikkiWines Apr 2, 2024
0d2a5aa
don't used combinedReportActions actually
NikkiWines Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pages/home/report/ReportActionsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ function ReportActionsView({
(action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && action.originalMessage && action.originalMessage.type === CONST.IOU.REPORT_ACTION_TYPE.CREATE,
);

if (report.total && moneyRequestActions.length < (reportPreviewAction?.childMoneyRequestCount ?? 0)) {
if (report.total && moneyRequestActions.length < (reportPreviewAction?.childMoneyRequestCount ?? 0) && isEmptyObject(transactionThreadReport)) {
const optimisticIOUAction = ReportUtils.buildOptimisticIOUReportAction(
CONST.IOU.REPORT_ACTION_TYPE.CREATE,
0,
Expand Down Expand Up @@ -528,7 +528,7 @@ function ReportActionsView({
}

return [...actions, createdAction];
}, [reportActions, report]);
}, [reportActions, report, transactionThreadReport]);

// Comments have not loaded at all yet do nothing
if (!reportActions.length) {
Expand Down
Loading