-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the navigation of leaving self-dm thread #39476
Fixing the navigation of leaving self-dm thread #39476
Conversation
@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: Native & iOS: mWeb SafariAndroidNiOSWeb.movAndroid: mWeb Chrome & iOS: NativeiOSNAndroidWeb.movMacOS: Chrome / SafariScreen.Recording.2024-04-03.at.10.40.23.PM.movMacOS: DesktopScreen.Recording.2024-04-03.at.10.48.41.PM.mov |
@abzokhattab Offline tests didn't go through, I don't see leave button in thread while offline cc: @luacmartins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good waiting for offline tests clarification
@Santhosh-Sellavel Correct the offline tests are not applicable as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all yours @luacmartins!
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.60-13 🚀
|
Details
Fixed Issues
$ #38689
PROPOSAL: #38689 (comment)
Tests
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-03.at.9.02.02.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-04-03.at.8.59.55.AM.mov
iOS: Native
Screen.Recording.2024-04-03.at.9.02.02.AM.mov
iOS: mWeb Safari
Screen.Recording.2024-04-03.at.8.59.55.AM.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-03.at.8.55.39.AM.mov
MacOS: Desktop
Screen.Recording.2024-04-03.at.9.02.53.AM.mov