-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tasks for guided setup #39951
Merged
mountiny
merged 69 commits into
Expensify:main
from
rezkiy37:feature/38771-tasks-for-guided-setup
Apr 21, 2024
+1,031
−100
Merged
Tasks for guided setup #39951
Changes from all commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
53e0ca3
feat: added new method for handliung onboarding, build new messages s…
barttom c34e8a2
feat: call method
barttom 9068ffd
Merge branch 'feat/38771/tasks-for-guided-setup' of https://github.co…
rezkiy37 880a34a
feat: added new method for handliung onboarding, build new messages s…
barttom c396f2a
feat: call method
barttom 9ad3329
feat: added optimistic data
barttom 9cff1f4
feat: added optimistic data
barttom 1077782
feat: update method
barttom 5e18a49
Merge branch 'feat/38771/tasks-for-guided-setup' of https://github.co…
rezkiy37 b37c394
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 28c66f3
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 4f8f78e
minor fixes of onboarding messages
rezkiy37 e08f94d
create CompleteGuidedSetupParams
rezkiy37 202b111
integrate setDisplayName
rezkiy37 fdb7f46
extend functions in ReportUtils
rezkiy37 b60ed0d
improve completeOnboarding
rezkiy37 f5486bb
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 4f291f0
simplify CompleteGuidedSetupParams
rezkiy37 a32e5ea
add todo
rezkiy37 30678e2
improve completeOnboarding
rezkiy37 40c5676
pass timestamp into getDBTimeWithSkew
rezkiy37 98175c1
pass createdOffset into buildOptimistic function
rezkiy37 64f4b92
fix bugs and improve completeOnboarding
rezkiy37 80b6b48
avoid text escaping
rezkiy37 2a78251
add replies config
rezkiy37 e97aa46
pass mentionMessage and prettify
rezkiy37 22cfe3b
change ordering of pages
rezkiy37 f5cd44b
fix bottom padding
rezkiy37 2adfe8f
pass current user info
rezkiy37 1fb2411
remove line
rezkiy37 2782025
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 beba934
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 c1145c6
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 0d23206
integrate OnboardingWork page
rezkiy37 19d7d50
move types
rezkiy37 ed44ffd
integrate onboarding work
rezkiy37 41851ac
clarify work cases
rezkiy37 23268d1
fix onboarding screen options
rezkiy37 80bb56c
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 52fde4a
add video to tasks
rezkiy37 5df95e0
fix workspace creating
rezkiy37 ca821a0
integrate video to tasks
rezkiy37 9591026
integrate OnboardingPurposeType type
rezkiy37 d87069d
integrate GuidedSetupData type
rezkiy37 e4a4fa6
use OnboardingPurposeType
rezkiy37 ef7f8c6
change progress bar values
rezkiy37 3c6e512
fix task actions ordering
rezkiy37 6eb2c29
integrate addition options
rezkiy37 820360f
fix default value of guideCalendarLink
rezkiy37 8142c95
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 2e7d5c0
fix task video assigning
rezkiy37 a443fb5
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 cb102de
minor improvement
rezkiy37 95ce5fc
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 f81ba49
cut task videos off
rezkiy37 18cf4a8
Revert "add video to tasks"
rezkiy37 070e933
fix mentionHandle
rezkiy37 41e7786
fix link of message
rezkiy37 897668c
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 6b4f19f
Merge branch 'main' of https://github.com/rezkiy37/Expensify into fea…
rezkiy37 76d419c
fix bold text
rezkiy37 67a2e10
add task types
rezkiy37 3ec3c82
complete tasks
rezkiy37 8cfbe4c
Revert "complete tasks"
rezkiy37 4e5a21b
Reapply "complete tasks"
rezkiy37 b1c34f1
integrate autocompleted tasks
rezkiy37 c3360e0
improve progress bar
rezkiy37 4b0354a
Merge branch 'main' into feature/38771-tasks-for-guided-setup
fabioh8010 555861c
Apply review changes
fabioh8010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
import type {OnboardingPurposeType} from '@src/CONST'; | ||
|
||
type CompleteGuidedSetupParams = { | ||
firstName: string; | ||
lastName: string; | ||
guidedSetupData: string; | ||
engagementChoice: OnboardingPurposeType; | ||
}; | ||
|
||
export default CompleteGuidedSetupParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We did not include
selfGuidedTourTask
in the tasks if the tour purpose iscombinedTrackSubmitOnboardingChoices.PERSONAL_SPEND
leading to this issue.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brunovjk Actually, the issue was introduced by this PR: #51153. The tour links did not exist when we implemented this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for that and thanks a lot for tracking. I will post i there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem! :)