-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] Reassure: refactor tests for more complex components #40163
[NoQA] Reassure: refactor tests for more complex components #40163
Conversation
4feb160
to
def351f
Compare
3e14c39
to
a4da5df
Compare
23bd2ac
to
6d3a8b1
Compare
@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I'm not sure if this one needs review, but I got bunch of errors while trying to run Screen.Recording.2024-04-23.at.11.27.00.mov |
@hungvu193 These warnings are not related to changes coming from this PR and do not impact Reassure tests. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariScreen.Recording.2024-04-23.at.11.27.00.movMacOS: Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.65-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
Details
This PR introduces refactor of Reassure test to make them less complex. We also want to focus on catching regressions in the part of the app that sticks to our metrics defined during the audit.
ReportScreen:
Composer
andReportActionsList
, where we checked all the necessary interactions. Let's just measure loading time and re-renders of theReportScreen
,SearchPage:
BaseSelection
already exist, so there's no need to add more tests here.SignInPage:
Fixed Issues
$ #39913
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop