Remove `MoneyRequestConfirmationList` and replace to `MoneyTemporaryForRefactorRequestConfirmationList` #40176

brunovjk · 2024-04-12T14:25:47Z

Details

This is a part of #29107 and is all about removing the original components and any of the duplicated efforts.

Old Component: MoneyRequestConfirmationList.
New Component MoneyTemporaryForRefactorRequestConfirmationList.

Fixed Issues

$ #39559
PROPOSAL: #39559 (comment)

Tests

This is a refactoring PR, everything should work the same as before.

The `MoneyRequestConfirmationList` component is utilized across various IOU types (send, split, request, track-expense) to confirm requests (manual, scan, distance). Therefore, comprehensive testing is required across all flows.

On the Confirmation Page, thoroughly test each field:
- Verify that the initial value matches the data entered in previous steps (e.g., creating the request).
- Edit each field, then press Next/Request/Send/Track, ... to proceed.
- After proceeding, verify that the value remains consistent with the previous step.
- Edit each field again and press Next/Request/Send/Track, ... without changing the value.
- Verify that the value remains unchanged and all other fields are correct.
- Edit each field again and press the Back button and confirm that the value remains unchanged and all other fields are correct.
- On the Confirmation Page press the Back button, press Next from the previous page, and confirm that the Confirmation Page retains its state.
After completing the field testing, press the Request button and confirm redirection to the corresponding chat (report).
For Split flows, click on the newly created report preview and verify redirection to the Confirmation Page. Ensure all fields are correct and expected. Additionally, verify the ability to edit editable fields.

Below are steps to reach the Confirmation Page in each flow:

Send Money (Global Fab):
1. Click on the Global Fab.
2. Press "Send Money".
3. Fill in the amount and press "Next".
4. Add a contact/user.
5. Verify the Confirmation Page and test all fields and buttons.
6. Press "Pay elsewhere".
7. Confirm redirection to the report chat with the new created report preview.
Request Money - Manual (Global Fab):
1. Click on the Global Fab.
2. Press "Request Money".
3. Click on "Manual" at the top.
4. Fill in the amount and press "Next".
5. Add a contact/user.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Request".
8. Confirm redirection to the report chat with the new created report preview.
Request Money - Scan (Global Fab):
1. Click on the Global Fab.
2. Press "Request Money".
3. Click on "Scan" at the top.
4. Upload a receipt.
5. Add a contact/user.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Request".
8. Confirm redirection to the report chat with the new created report preview.
Request Money - Distance (Global Fab):
1. Click on the Global Fab.
2. Press "Request Money".
3. Click on "Distance" at the top.
4. Add two or more valid waypoints.
5. Press "Next".
6. Add a contact/user.
7. Verify the Confirmation Page and test all fields and buttons.
8. Press "Request".
9. Confirm redirection to the report chat with the new created report preview.
Track Expense - Manual (Global Fab):
1. Click on the Global Fab.
2. Press "Track Expense".
3. Click on "Manual" at the top.
4. Fill in the amount and press "Next".
5. Verify the Confirmation Page and test all fields and buttons.
6. Press "Track Expense".
7. Confirm redirection to the report chat with the new created report preview.
Track Expense - Scan (Global Fab):
1. Click on the Global Fab.
2. Press "Track Expense".
3. Click on "Scan" at the top.
4. Upload a receipt.
5. Verify the Confirmation Page and test all fields and buttons.
6. Press "Track Expense".
7. Confirm redirection to the report chat with the new created report preview.
Track Expense - Distance (Global Fab):
1. Click on the Global Fab.
2. Press "Track Expense".
3. Click on "Distance" at the top.
4. Add two or more valid waypoints.
5. Press "Next".
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Track Expense".
8. Confirm redirection to the report chat with the new created report preview.
Split Bill - Manual (Workspace Default Chat):
1. Go to a workspace default chat (admins or announce rooms).
2. Click on the "+" icon.
3. Press "Split Bill".
4. Click on "Manual" at the top.
5. Fill in the amount and press "Next".
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Split".
8. Confirm redirection to the report chat with the new created report preview.
9. Click on the newly created "Split Preview".
10. Verify all fields have expected values.
Split Bill - Scan (Workspace Default Chat):
1. Go to a workspace default chat (admins or announce rooms).
2. Click on the "+" icon.
3. Press "Split Bill".
4. Click on "Scan" at the top.
5. Upload a receipt.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Split".
8. Confirm redirection to the report chat with the new created report preview.
9. Click on the newly created "Receipt Preview".
10. Verify all fields have expected values (amount usually remains 0.00 awaiting scanning).
11. Test all enable fields to ensure editing functionality.
Send Money (1:1 Chat):
1. Go to a 1:1 chat.
2. Click on the "+" icon.
3. Press "Send Money".
4. Fill in the amount and press "Next".
5. Verify the Confirmation Page and test all fields and buttons.
6. Press "Pay elsewhere".
7. Confirm redirection to the report chat with the new created report preview.
Request Money - Manual (1:1 Chat):
1. Go to a 1:1 chat.
2. Click on the "+" icon.
3. Press "Request Money".
4. Click on "Manual" at the top.
5. Fill in the amount and press "Next".
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Request".
8. Confirm redirection to the report chat with the new created report preview.
Request Money - Scan (1:1 Chat):
1. Go to a 1:1 chat.
2. Click on the "+" icon.
3. Press "Request Money".
4. Click on "Scan" at the top.
5. Upload a receipt.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Request".
8. Confirm redirection to the report chat with the new created report preview.
Split Bill - Manual (1:1 Chat):
1. Go to a 1:1 chat.
2. Click on the "+" icon.
3. Press "Split Bill".
4. Click on "Manual" at the top.
5. Fill in the amount and press "Next".
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Split".
8. Confirm redirection to the report chat with the new created report preview.
9. Click on the newly created "Split Preview".
10. Verify all fields have expected values.
Split Bill - Scan (1:1 Chat):
1. Go to a 1:1 chat.
2. Click on the "+" icon.
3. Press "Split Bill".
4. Click on "Scan" at the top.
5. Upload a receipt.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Split".
8. Confirm redirection to the report chat with the new created report preview.
9. Click on the newly created "Receipt Preview".
10. Verify all fields have expected values (amount usually remains 0.00 awaiting scanning).
11. Test all enable fields to ensure editing functionality.
Track Expense - Manual (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Track Expense".
4. Click on "Manual" at the top.
5. Fill in the amount and press "Next".
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Track expense".
8. Confirm redirection to the report chat with the new created report preview.
Track Expense - Scan (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Track Expense".
4. Click on "Scan" at the top.
5. Upload a receipt.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Track expense".
8. Confirm redirection to the report chat with the new created report preview.
Track Expense - Distance (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Track Expense".
4. Click on "Distance" at the top.
5. Add two or more valid waypoints.
6. Press "Next".
7. Verify the Confirmation Page and test all fields and buttons.
8. Press "Track expense".
9. Confirm redirection to the report chat with the new created report preview.
Request Money - Manual (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Request Money".
4. Click on "Manual" at the top.
5. Fill in the amount and press "Next".
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Request".
8. Confirm redirection to the report chat with the new created report preview.
Request Money - Scan (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Request Money".
4. Click on "Scan" at the top.
5. Upload a receipt.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Request".
8. Confirm redirection to the report chat with the new created report preview.
Request Money - Distance (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Request Money".
4. Click on "Distance" at the top.
5. Add two or more valid waypoints.
6. Press "Next".
7. Verify the Confirmation Page and test all fields and buttons.
8. Press "Request".
9. Confirm redirection to the report chat with the new created report preview.
Split Bill - Manual (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Split Bill".
4. Click on "Manual" at the top.
5. Fill in the amount and press "Next".
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Split".
8. Confirm redirection to the report chat with the new created report preview.
9. Click on the newly created "Split Preview".
10. Verify all fields have expected values.
11. Test all enable fields to ensure editing functionality.
Split Bill - Scan (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Split Bill".
4. Click on "Scan" at the top.
5. Upload a receipt.
6. Verify the Confirmation Page and test all fields and buttons.
7. Press "Split".
8. Confirm redirection to the report chat with the new created report preview.
9. Click on the newly created "Receipt Preview".
10. Verify all fields have expected values (amount usually remains 0.00 awaiting scanning).
11. Test all enable fields to ensure editing functionality.
Split Bill - Distance (Workspace Chat):
1. Go to a workspace chat.
2. Click on the "+" icon.
3. Press "Split Bill".
4. Click on "Distance" at the top.
5. Add two or more valid waypoints.
6. Press "Split".
7. Confirm redirection to the report chat with the new created report preview.
8. Click on the newly created "Receipt Preview".
9. Verify all fields have expected values.
10. Test all enable fields to ensure editing functionality.
Verify that no errors appear in the JS console

Offline tests

Same as Tests, mirroring online ones with optimistic values.

Verify that no errors appear in the JS console

QA Steps

Same as Tests

PR Author Checklist

Screenshots/Videos

iOS: Native

39559.-.iOS_.Native.mp4

iOS: mWeb Safari

39559.-.iOS_.mWeb.Safari.mp4

MacOS: Chrome / Safari

39559.-.MacOs_.Safari.mp4

MacOS: Desktop

39559.-.MacOS_.Desktop.mp4

Android: Native

Android: mWeb Chrome

…its uses

melvin-bot · 2024-04-12T14:25:53Z

@eh2077 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

brunovjk · 2024-04-13T22:37:38Z

@eh2077 our PR is ready for review.
Im struggling with my Android build, can you assist me with test/videos here?
Thank you very much.

src/components/MoneyRequestConfirmationList.tsx

eh2077 · 2024-04-15T06:54:59Z

src/components/MoneyRequestConfirmationList.tsx


    useEffect(() => {
        if (!shouldCalculateDistanceAmount) {
            return;
        }

        const amount = DistanceRequestUtils.getDistanceRequestAmount(distance, unit, rate ?? 0);
-        IOU.setMoneyRequestAmount(amount);
-    }, [shouldCalculateDistanceAmount, distance, rate, unit]);
+        IOU.setMoneyRequestAmount_temporaryForRefactor(transaction?.transactionID ?? '', amount, currency ?? '');


IOU.setMoneyRequestAmount can be replaced by IOU.setMoneyRequestAmount_temporaryForRefactor right? If so, then I think we should remove IOU.setMoneyRequestAmount and rename the temporary method.

I'm not sure if IOU.setMoneyRequestAmount_temporaryForRefactor can fit split distance request.

I believe so, however, you were right about SplitBill, I changed it to be dynamic when going to CREATE OR EDIT. Can you take a look, please? Especially this commit

src/components/MoneyRequestConfirmationList.tsx

eh2077 · 2024-04-15T08:07:27Z

@brunovjk I think we should test each IOU flow separately to ensure that these critical flows are not broken.

We have four IOU types, [send, split, request, track-expense], and three request types, [manual, scan, distance]. There're 10 flows in total

send money - manual
request money - manual
request money - scan
request money - distance in workspace
split money - manual
split money - scan
split money - distance in workspace
track-expense - manual
track-expense - scan
track-expense - distance

Would you like to update test steps?

Co-authored-by: Eric Han <117511920+eh2077@users.noreply.github.com>

brunovjk · 2024-04-17T19:13:25Z

I found a bug - [Request Money - Scan] uploading PDF receipt not working

I can reproduce this bug on main:

@eh2077 I don't believe it's our PR that's causing it, but I'll try to investigate anyway.

EDIT: "There is a PR to fix it: #40351"

eh2077 · 2024-04-18T07:42:00Z

@brunovjk Thanks for starting this discussion on Slack! The fix PR #40385 should be merged soon.

eh2077 · 2024-04-18T07:42:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

mobile-chrome.mov

iOS: Native

0-ios.mp4

iOS: mWeb Safari

0-mobile-safari.mp4

MacOS: Chrome / Safari

0-send-requst-track-split-money.mp4

MacOS: Desktop

0-desktop.mp4

brunovjk · 2024-04-18T10:07:36Z

Nice!!! Thank you @eh2077 :D
Now it's up to @tgolen, right?

eh2077

LGTM and tested well!

tgolen · 2024-04-18T15:16:41Z

I can review this today, but there are a few conflicts currently. Can you please fix them before I review it? Thanks!

brunovjk · 2024-04-18T16:56:30Z

Resolved the conflicts, let me test again.

tgolen · 2024-04-18T17:03:42Z

OK, the changes look fine to me. Let me know once you've run through a few tests and then I'll merge it.

brunovjk · 2024-04-18T17:19:02Z

Good to go @tgolen :D

melvin-bot · 2024-04-18T18:22:57Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

src/libs/actions/IOU.ts

OSBotify · 2024-04-23T23:42:55Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Krishna2323 · 2024-04-26T17:31:18Z

@eh2077 @brunovjk, I think that while you were resolving conflicts, you mistakenly added back the dependencies that were removed in this PR. This issue is now again reproducible for tags.

brunovjk · 2024-04-26T17:57:42Z

Thanks, @Krishna2323, for catching that. My apologies for the reintroduced issue. I'm available to submit another PR if the team agrees. Do we only need to remove transaction and transactionID

App/src/components/MoneyRequestConfirmationList.tsx

Line 523 in 035adb8

}, [policyTagLists, transaction, transactionID, policyTags, canUseViolations]);

and add back "eslint-disable-next-line"?

Krishna2323 · 2024-04-26T18:02:30Z

@brunovjk, I assume transactionID remains unchanged when transaction details are altered, so we can leave it as is. We only need to remove transaction, but please verify this while recording the videos to be certain. Thanks :)

eh2077 · 2024-04-29T12:27:03Z

@eh2077 @brunovjk, I think that while you were resolving conflicts, you mistakenly added back the dependencies that were removed in this PR. This issue is now again reproducible for tags.

@Krishna2323 Sorry, I can't reproduce #38744 on production and staging anymore. I try both category and tag.

@brunovjk Can you reproduce that?

brunovjk · 2024-04-29T13:16:34Z

@eh2077 Actually not exactly like the OP of the issue. However, I can see some inconsistencies (different lag/delay time) when selecting and deselecting categories and tags. But absolutely nothing like the problem presented before.

brunovjk and others added 4 commits April 12, 2024 10:37

Replace all uses of the Old Component with the New Component

747b8ea

Merge branch 'Expensify:main' into fix/39559

18f9faf

Remove Old Component

dc3e2e5

Rename 'MoneyTemporaryForRefactorRequestConfirmationList' and in all …

032f118

…its uses

brunovjk requested a review from a team as a code owner April 12, 2024 14:25

melvin-bot bot requested review from eh2077 and removed request for a team April 12, 2024 14:25

brunovjk changed the title ~~Remove 'MoneyRequestConfirmationList' and replace to MoneyTemporaryForRefactorRequestConfirmationList~~ Remove MoneyRequestConfirmationList and replace to MoneyTemporaryForRefactorRequestConfirmationList Apr 12, 2024

brunovjk and others added 2 commits April 13, 2024 07:48

Merge branch 'main' into fix/39559

e68ffdb

fix lint

fc00866

brunovjk mentioned this pull request Apr 13, 2024

[HOLD for payment 2024-05-02] [$250] Remove MoneyRequestConfirmationList.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestConfirmationList.js #39559

Closed

eh2077 reviewed Apr 15, 2024

View reviewed changes

brunovjk and others added 15 commits April 15, 2024 08:01

Merge branch 'Expensify:main' into fix/39559

270f94a

Add validation error for category

387586a

reuse ShowMoreButton

4e8fef9

add tags within components

650b186

Add useCallback dependency

e669b1f

added small adjustments

f7f7c14

'resolve comments'

0bee35b

fix type

cf1e559

canModifyParticipantsProp

b77d574

fix lint

35c3781

Update src/components/MoneyRequestConfirmationList.tsx

8c509e3

Co-authored-by: Eric Han <117511920+eh2077@users.noreply.github.com>

return with comment

4877ce3

Put 'transaction?.transactionID ?? ''' is a single variable

9f66818

fix lint

402fa4f

run prettier

c11bc0a

Merge remote-tracking branch 'origin/main' into fix/39559

c4e4dab

brunovjk requested a review from eh2077 April 17, 2024 19:15

eh2077 approved these changes Apr 18, 2024

View reviewed changes

melvin-bot bot requested a review from tgolen April 18, 2024 11:05

resolve conflicts

222fd14

tgolen approved these changes Apr 18, 2024

View reviewed changes

tgolen merged commit 25bf0f8 into Expensify:main Apr 18, 2024
15 checks passed

brunovjk deleted the fix/39559 branch April 18, 2024 18:25

shubham1206agra reviewed Apr 19, 2024

View reviewed changes

src/libs/actions/IOU.ts Show resolved Hide resolved

brunovjk restored the fix/39559 branch April 21, 2024 00:20

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

shubham1206agra mentioned this pull request Apr 22, 2024

[HOLD for payment 2024-05-02] Split scan - Missing Split button in the split menu RHP #40709

Closed

6 tasks

This was referenced Apr 23, 2024

[HOLD /react-native-live-markdown#366] [$250] IOU - one character descriptions are not saved #40799

Closed

[$250][HOLD #37374] Track expense - Waypoints swap places when tap and hold #40818

Closed

brunovjk mentioned this pull request Apr 27, 2024

Fix reintroduced dependencies from conflict resolution #41152

Merged

49 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove `MoneyRequestConfirmationList` and replace to `MoneyTemporaryForRefactorRequestConfirmationList` #40176

Remove `MoneyRequestConfirmationList` and replace to `MoneyTemporaryForRefactorRequestConfirmationList` #40176

brunovjk commented Apr 12, 2024 •

edited

Loading

melvin-bot bot commented Apr 12, 2024

brunovjk commented Apr 13, 2024

eh2077 Apr 15, 2024

brunovjk Apr 15, 2024

eh2077 commented Apr 15, 2024

brunovjk commented Apr 17, 2024 •

edited

Loading

eh2077 commented Apr 18, 2024

eh2077 commented Apr 18, 2024 •

edited

Loading

brunovjk commented Apr 18, 2024 •

edited

Loading

eh2077 left a comment

tgolen commented Apr 18, 2024

brunovjk commented Apr 18, 2024

tgolen commented Apr 18, 2024

brunovjk commented Apr 18, 2024 •

edited

Loading

melvin-bot bot commented Apr 18, 2024

OSBotify commented Apr 23, 2024

Krishna2323 commented Apr 26, 2024

brunovjk commented Apr 26, 2024

Krishna2323 commented Apr 26, 2024

eh2077 commented Apr 29, 2024

brunovjk commented Apr 29, 2024

Remove MoneyRequestConfirmationList and replace to MoneyTemporaryForRefactorRequestConfirmationList #40176

Remove MoneyRequestConfirmationList and replace to MoneyTemporaryForRefactorRequestConfirmationList #40176

Conversation

brunovjk commented Apr 12, 2024 • edited Loading

Details

Fixed Issues

Tests

The MoneyRequestConfirmationList component is utilized across various IOU types (send, split, request, track-expense) to confirm requests (manual, scan, distance). Therefore, comprehensive testing is required across all flows.

Below are steps to reach the Confirmation Page in each flow:

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 12, 2024

brunovjk commented Apr 13, 2024

eh2077 Apr 15, 2024

Choose a reason for hiding this comment

brunovjk Apr 15, 2024

Choose a reason for hiding this comment

eh2077 commented Apr 15, 2024

brunovjk commented Apr 17, 2024 • edited Loading

eh2077 commented Apr 18, 2024

eh2077 commented Apr 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

brunovjk commented Apr 18, 2024 • edited Loading

eh2077 left a comment

Choose a reason for hiding this comment

tgolen commented Apr 18, 2024

brunovjk commented Apr 18, 2024

tgolen commented Apr 18, 2024

brunovjk commented Apr 18, 2024 • edited Loading

melvin-bot bot commented Apr 18, 2024

OSBotify commented Apr 23, 2024

Krishna2323 commented Apr 26, 2024

brunovjk commented Apr 26, 2024

Krishna2323 commented Apr 26, 2024

eh2077 commented Apr 29, 2024

brunovjk commented Apr 29, 2024

Remove `MoneyRequestConfirmationList` and replace to `MoneyTemporaryForRefactorRequestConfirmationList` #40176

Remove `MoneyRequestConfirmationList` and replace to `MoneyTemporaryForRefactorRequestConfirmationList` #40176

brunovjk commented Apr 12, 2024 •

edited

Loading

The `MoneyRequestConfirmationList` component is utilized across various IOU types (send, split, request, track-expense) to confirm requests (manual, scan, distance). Therefore, comprehensive testing is required across all flows.

brunovjk commented Apr 17, 2024 •

edited

Loading

eh2077 commented Apr 18, 2024 •

edited

Loading

brunovjk commented Apr 18, 2024 •

edited

Loading

brunovjk commented Apr 18, 2024 •

edited

Loading