-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HelpDot] fix numbering #40207
[HelpDot] fix numbering #40207
Conversation
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
@rushatgabhane try pulling |
@yuwenmemon helpdot workflow is expected to fail on forks because cloudflare does not have permission to my repo |
@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Not an emergency, see the above comment for the HelpDot test |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 1.4.63-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.63-21 🚀
|
The numbered list started from 1 again because of a table in-between.
Details
Fixed Issues
$ https://expensify.slack.com/archives/C02QSAC6BJ8/p1712838326748319?thread_ts=1712786824.904389&cid=C02QSAC6BJ8
PROPOSAL:
Tests
cd docs && npm run createDocsRoutes && bundle exec jekyll serve --livereload --safe
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos