-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO QA] Fullstory integration #40294
[NO QA] Fullstory integration #40294
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have read the CLA Document and I hereby sign the CLA |
fdd70cd
to
6b5e8d7
Compare
- React-Native Android - React-Native IOS - Web Functionality included: - Session recording - Essential Identity resolution Functionality added: - FSPage - Mobile Pages API Platforms affected: - Android - IOs Typescript types definitions added. Unit test fixed, fixed eslint errors. Signed-off-by: Oleksii Vagin <oleksii@leanconvert.com>
6b5e8d7
to
93ff19f
Compare
1928c3a
into
Expensify:fullstory-integration
🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.65-0 🚀
|
@danieldoglas Could someone please verify this PR internally? The QA team doesn't have access to Fullstory. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.66-0 🚀
|
🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.66-0 🚀
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀
|
Details
Fullstory integration
Functionality included:
What's not included:
native parameter should be switched to false for web/desktop (line 26)
https://app.fullstory.com/ui/o-1WN56P-na1/settings/general
Tests
QA Steps
PR Author Checklist
Tests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://drive.google.com/file/d/1rU2BYJ_AW5ibyqlNl-GhG5T2V7f71vCi/view?usp=drive_linkiOS: Native
https://drive.google.com/file/d/1HSQzY1uBctBuh1V-uEGy7dRVMuoIYD3D/view?usp=drive_link https://drive.google.com/file/d/1ClGEI9TD8EdbNFjKwRSEEzlmh3MyM3AL/view?usp=drive_linkMacOS: Chrome / Safari
https://drive.google.com/file/d/1p0lqYvh2Ynl_HhwaLLsaBFTfs-8YyaHZ/view?usp=drive_linkMacOS: Desktop
https://drive.google.com/file/d/1Ymg0aQSsXhbuiZCAd9LLbt1FlMySMjsn/view?usp=drive_link