Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Fullstory integration #40294

Merged
merged 5 commits into from
Apr 18, 2024
Merged

[NO QA] Fullstory integration #40294

merged 5 commits into from
Apr 18, 2024

Conversation

LCOleksii
Copy link
Contributor

@LCOleksii LCOleksii commented Apr 16, 2024 •
edited by danieldoglas
Loading

Details

Fullstory integration

  • React-Native Android
  • React-Native IOS
  • React-Native Web

Functionality included:

  • Mobile Pages API
  • Session recording
  • Essential Identity resolution

What's not included:

  • Cross-platform build automation at babel.config.js
    native parameter should be switched to false for web/desktop (line 26)

    ['@fullstory/babel-plugin-annotate-react', {
    native: false,
    setFSTagName: true,
    },],

  • GTM Tag for web/desktop should be configured according to:
    https://app.fullstory.com/ui/o-1WN56P-na1/settings/general

Tests

  • Verify that no errors appear in the JS console
  • Verify App launches without any issues,
  • Verify transition between states without any issues

QA Steps

  • Launch the App
  • Log in
  • Navigate the App to switch between different states
  • Open https://app.fullstory.com/ui/o-1WN56P-na1/
  • Login to Fullstory
  • Navigate to Fullstory Dashboards
  • Filter view most recent activity
  • Verify that session is recorded
  • Disconnect internet access on the testing device
  • Verify that no errors related to the Fullstory integration appear in the JS console

PR Author Checklist

  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native https://drive.google.com/file/d/1rU2BYJ_AW5ibyqlNl-GhG5T2V7f71vCi/view?usp=drive_link
iOS: Native https://drive.google.com/file/d/1HSQzY1uBctBuh1V-uEGy7dRVMuoIYD3D/view?usp=drive_link https://drive.google.com/file/d/1ClGEI9TD8EdbNFjKwRSEEzlmh3MyM3AL/view?usp=drive_link
MacOS: Chrome / Safari https://drive.google.com/file/d/1p0lqYvh2Ynl_HhwaLLsaBFTfs-8YyaHZ/view?usp=drive_link
MacOS: Desktop https://drive.google.com/file/d/1Ymg0aQSsXhbuiZCAd9LLbt1FlMySMjsn/view?usp=drive_link

@LCOleksii LCOleksii requested a review from a team as a code owner April 16, 2024 14:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team April 16, 2024 14:43
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 16, 2024

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@danieldoglas danieldoglas requested review from danieldoglas and removed request for srikarparsi April 16, 2024 14:45
@LCOleksii
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@danieldoglas danieldoglas changed the base branch from main to fullstory-integration April 18, 2024 13:21
@LCOleksii LCOleksii force-pushed the fullstory-integration branch 2 times, most recently from fdd70cd to 6b5e8d7 Compare April 18, 2024 13:46
@LCOleksii
Fullstory integration.
93ff19f 
- React-Native Android
- React-Native IOS
- Web

Functionality included:
- Session recording
- Essential Identity resolution

Functionality added:
- FSPage - Mobile Pages API

Platforms affected:
- Android
- IOs

Typescript types definitions added.
Unit test fixed, fixed eslint errors.

Signed-off-by: Oleksii Vagin <oleksii@leanconvert.com>
@danieldoglas danieldoglas merged commit 1928c3a into Expensify:fullstory-integration Apr 18, 2024
16 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Apr 23, 2024
Closed
74 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.65-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@kbecciv
Copy link

kbecciv commented Apr 24, 2024

@danieldoglas Could someone please verify this PR internally? The QA team doesn't have access to Fullstory.

@hungvu193 hungvu193 mentioned this pull request Apr 24, 2024
Closed
6 tasks
@danieldoglas danieldoglas changed the title Fullstory integration [NO QA] Fullstory integration Apr 24, 2024
mananjadhav added a commit to mananjadhav/App that referenced this pull request Apr 24, 2024
@mananjadhav
Revert "Merge pull request Expensify#40294 from LCOleksii/fullstory-i…
bcc705e 
…ntegration"

This reverts commit 1928c3a, reversing
changes made to 9b839f4.
@github-actions github-actions bot mentioned this pull request Apr 25, 2024
Closed
53 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.66-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 failure ❌
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/danieldoglas in version: 1.4.66-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.66-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldoglas danieldoglas danieldoglas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LCOleksii @OSBotify @kbecciv @danieldoglas