-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude domain rooms check from canSeeDefaultRooms #40298
Conversation
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
I pinged the internal team to have them check the PR build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the fix works 👍
@@ -503,12 +503,6 @@ Onyx.connect({ | |||
callback: (value) => (allReports = value), | |||
}); | |||
|
|||
let doesDomainHaveApprovedAccountant = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should remove doesDomainHaveApprovedAccountant
from the BE now? 🤔 cc @yuwenmemon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah if we're not using it in the front-end anymore I can certainly rip it out of the back end!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It originally came from: https://github.com/Expensify/Expensify/issues/257570
I presume we're just showing domain rooms universally now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we're hiding them from approved accountants: https://expensify.slack.com/archives/C03SSAQ7P/p1713199776085039
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, same same for this though! I created an issue here so I don't forget: https://github.com/Expensify/Expensify/issues/389013
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@trjExpensify tagging you as per the QA step.
|
I can't find the domain room on staging (nor is it in my LHN), so looks good to me. Same as the adhoc build @flodnv asked me to test the other day. 👍 |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀
|
Details
Exclude domain rooms check from canSeeDefaultRooms.
Fixed Issues
$ #40249
PROPOSAL: #40249 (comment)
Tests
Tested internally via a PR build here: https://expensify.slack.com/archives/C03SSAQ7P/p1713445484514769?thread_ts=1713199776.085039&cid=C03SSAQ7P
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop