fix-39841: Finetune animation durations #40369

allroundexperts · 2024-04-17T18:39:26Z

Details

This PR fine tunes the highlighted menu item animation durations.

Fixed Issues

$ #39841
PROPOSAL: N/A

Tests

Create a new workspace
Go to the workspace settings
Enable a feature.

Verify that the design requirements mentioned here are satisfied.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Create a new workspace
Go to the workspace settings
Enable a feature.

Verify that the design requirements mentioned here are satisfied.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-17.at.11.32.42.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-04-17.at.11.13.25.PM.mov

iOS: Native

Screen.Recording.2024-04-17.at.11.12.35.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-04-17.at.11.07.40.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.11.05.02.PM.mov

MacOS: Desktop

Screen.Recording.2024-04-17.at.11.06.23.PM.mov

melvin-bot · 2024-04-17T18:39:32Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-18.at.16.14.23.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-04-18.at.15.35.51.mov

Screen.Recording.2024-04-18.at.15.38.42.mov

iOS: mWeb Safari

Screen.Recording.2024-04-18.at.15.19.34.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-18.at.14.56.00.mov

Screen.Recording.2024-04-18.at.14.57.32.mov

Screen.Recording.2024-04-18.at.15.23.17.mov

MacOS: Desktop

Screen.Recording.2024-04-18.at.14.59.47.mov

sobitneupane · 2024-04-18T09:59:48Z

@allroundexperts I feel like it looks quite different in light mode. It gets lighter at the start and again gets darker before going lighter. Can you please verify if its working as expected in light mode?

Screen.Recording.2024-04-18.at.15.24.18.mov

Screen.Recording.2024-04-18.at.15.24.43.mov

allroundexperts · 2024-04-18T19:53:27Z

@Expensify/design Can you please verify if the above changes are fine?

dubielzyk-expensify · 2024-04-19T00:34:26Z

This is looking nice! We don't want that quick flash that happens.

I actually just animate from appBg to row-hover, then back to appBg. It looks like there's multiple colors going on here?

mountiny · 2024-04-20T19:25:53Z

Waiting for approval from @Expensify/design

allroundexperts · 2024-04-21T21:07:45Z

@dubielzyk-expensify Is the following fine? I used the same colours as you mentioned.

Screen.Recording.2024-04-22.at.2.07.05.AM.mov

dubielzyk-expensify · 2024-04-22T01:02:15Z

This is looking lovely. The animation where the workflow item comes in starts immediately and almost overlaps with the react navigation view animation. Can we add like 50ms delay so that the view can animate out and then the animation starts.

Can I get a desktop screen recording as well?

Appreciate your patience and effort on this. It's one of those things were there's minor tweaking back and forth but the end result is awesome and delightful 😄

github-actions · 2024-04-22T17:47:40Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/40369/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/40369/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://40369.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

allroundexperts · 2024-04-24T22:28:48Z

@dubielzyk-expensify Made it so that it waits for the screen transition to end.

Screen.Recording.2024-04-25.at.3.27.39.AM.mov

allroundexperts · 2024-04-24T22:31:31Z

@dubielzyk-expensify Desktop recording

Screen.Recording.2024-04-25.at.3.30.57.AM.mov

sobitneupane

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-04-25.at.16.09.24.mov

iOS: mWeb Safari

Screen.Recording.2024-04-25.at.15.30.47.mov

Screen.Recording.2024-04-25.at.15.31.14.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-25.at.15.22.00.mov

Screen.Recording.2024-04-25.at.15.22.44.mov

MacOS: Desktop

Screen.Recording.2024-04-25.at.15.26.38.mov

Screen.Recording.2024-04-25.at.15.28.16.mov

sobitneupane · 2024-04-25T10:27:05Z

Over to the design team. I will complete the checklist once approved by the design team.

shawnborton · 2024-04-25T12:28:32Z

Feelin' good to me! But let's see what @dubielzyk-expensify has to say before merging.

dubielzyk-expensify · 2024-04-26T02:21:15Z

Yaaay! This is looks awesome! 😄 No notes from me

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mountiny

Code changes look good to me, but I wanted to confirm this change was noted, now when the feature is enabled on desktop, we do not navigate to the specific feature page. We show the highlight and remain on the more features page.

I think its fine and makes it smoother rather than the abrupt navigation after toggling the feature on, but I did not see it mentioned in the comments above

dubielzyk-expensify · 2024-04-26T10:07:40Z

It's intentional and working as it should 😄

OSBotify · 2024-04-26T23:21:11Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.67-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2024-04-27T22:47:59Z

This PR is failing because of issue #39841

The issue is reproducible in: Web

20240427_154104.mp4

OSBotify · 2024-04-29T23:12:58Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-30T00:40:27Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

finetune animation durations

57b0aa8

allroundexperts requested a review from a team as a code owner April 17, 2024 18:39

melvin-bot bot requested review from sobitneupane and removed request for a team April 17, 2024 18:39

allroundexperts mentioned this pull request Apr 17, 2024

[HOLD for payment 2024-06-06] [HOLD for payment 2024-05-06] Web - Features - Feature row in left side bar appears with delay after the page opens on the right #39841

Closed

6 tasks

sobitneupane reviewed Apr 18, 2024

View reviewed changes

Merge branch 'main' into fix-39841

cd42251

mountiny assigned allroundexperts Apr 20, 2024

mountiny requested review from mountiny and dubielzyk-expensify April 20, 2024 19:25

Merge branch 'main' into fix-39841

4940383

feat: use appBG colour for highlight

841a270

mountiny added the Ready To Build label Apr 22, 2024

allroundexperts added 2 commits April 25, 2024 03:20

merge with main

cc7e9d0

add transition end check

6847af4

sobitneupane reviewed Apr 25, 2024

View reviewed changes

dubielzyk-expensify approved these changes Apr 26, 2024

View reviewed changes

sobitneupane approved these changes Apr 26, 2024

View reviewed changes

mountiny approved these changes Apr 26, 2024

View reviewed changes

mountiny merged commit d908a2b into Expensify:main Apr 26, 2024
16 of 19 checks passed

github-actions bot mentioned this pull request Apr 26, 2024

Deploy Checklist: New Expensify 2024-04-26 #41122

Closed

63 tasks

Krishna2323 mentioned this pull request Apr 27, 2024

[$250] IOS - More features - Enabled feature is not showing in workspace page after enabling it #41142

Closed

6 tasks

roryabraham mentioned this pull request Apr 28, 2024

Revert "fix-39841: Finetune animation durations" #41176

Merged

allroundexperts mentioned this pull request May 1, 2024

Navigate to accounting page #41428

Closed

48 tasks

allroundexperts mentioned this pull request May 12, 2024

fix: re-add finetunings #42026

Merged

50 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix-39841: Finetune animation durations #40369

fix-39841: Finetune animation durations #40369

allroundexperts commented Apr 17, 2024

melvin-bot bot commented Apr 17, 2024

sobitneupane left a comment •

edited

Loading

sobitneupane commented Apr 18, 2024

allroundexperts commented Apr 18, 2024

dubielzyk-expensify commented Apr 19, 2024

mountiny commented Apr 20, 2024

allroundexperts commented Apr 21, 2024

dubielzyk-expensify commented Apr 22, 2024 •

edited

Loading

github-actions bot commented Apr 22, 2024

allroundexperts commented Apr 24, 2024

allroundexperts commented Apr 24, 2024

sobitneupane left a comment •

edited

Loading

sobitneupane commented Apr 25, 2024

shawnborton commented Apr 25, 2024

dubielzyk-expensify commented Apr 26, 2024

sobitneupane left a comment

mountiny left a comment

dubielzyk-expensify commented Apr 26, 2024

OSBotify commented Apr 26, 2024

kbecciv commented Apr 27, 2024

OSBotify commented Apr 29, 2024

OSBotify commented Apr 30, 2024

fix-39841: Finetune animation durations #40369

fix-39841: Finetune animation durations #40369

Conversation

allroundexperts commented Apr 17, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 17, 2024

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented Apr 18, 2024

allroundexperts commented Apr 18, 2024

dubielzyk-expensify commented Apr 19, 2024

mountiny commented Apr 20, 2024

allroundexperts commented Apr 21, 2024

dubielzyk-expensify commented Apr 22, 2024 • edited Loading

github-actions bot commented Apr 22, 2024

allroundexperts commented Apr 24, 2024

allroundexperts commented Apr 24, 2024

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane commented Apr 25, 2024

shawnborton commented Apr 25, 2024

dubielzyk-expensify commented Apr 26, 2024

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

mountiny left a comment

Choose a reason for hiding this comment

dubielzyk-expensify commented Apr 26, 2024

OSBotify commented Apr 26, 2024

kbecciv commented Apr 27, 2024

OSBotify commented Apr 29, 2024

OSBotify commented Apr 30, 2024

sobitneupane left a comment •

edited

Loading

dubielzyk-expensify commented Apr 22, 2024 •

edited

Loading

sobitneupane left a comment •

edited

Loading