-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes typos, punctuation, spacing and formating #40487
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I have read the CLA Document and I hereby sign the CLA |
Recheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@grjan7 thank you for the PR!
Just to clarify, this PR like our other PR's does not qualify for bounty.
If you're fine with it, I am happy to approve. You need to sign CLA and also complete the checklist
@MonilBhavsar, I am fine with that. I'll complete rest of the process as well. |
This comment was marked as outdated.
This comment was marked as outdated.
See this PR for reference #40428 |
@MonilBhavsar, do I have to check every box to pass the |
yes |
Ok |
@grjan7 You need to have all your commits signed. Your first two commits are no signed |
Ok, I'll sign them. |
@MonilBhavsar, I could not sign the commits. So, I'll submit a new PR from another branch with signed commits. |
@MonilBhavsar, I have submitted another [PR] (#40859) with signed commits. So, I am closing this PR. |
Details
Fixes the following in the
.md
files indesktop/*.md
andcontributingGuides/*.md
:Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop